8000 Optimize/unit tests by tinohager · Pull Request #803 · nager/Nager.Date · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Optimize/unit tests #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025
Merged

Optimize/unit tests #803

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c90ba6
Optimize Unit Tests
tinohager May 9, 2025
4157c56
Merge branch 'main' into optimize/unit-tests
tinohager May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 42 additions & 18 deletions src/Nager.Date.UnitTest/Common/HolidaySystemTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public class HolidaySystemTest
{
[TestMethod]

public void CheckPublicHolidayProviders()
public void GetHolidays_ForEveryCountry()
{
var startYear = DateTime.Today.Year - 100;
var endYear = DateTime.Today.Year + 100;
Expand Down Expand Up @@ -41,7 +41,6 @@ public void CheckPublicHolidayProviders()
}

[TestMethod]
[Ignore]
public void Check_NoPublicHolidays_MoveInAnOtherYear()
{
var startYear = DateTime.Today.Year - 100;
Expand All @@ -51,41 +50,64 @@ public void Check_NoPublicHolidays_MoveInAnOtherYear()
{
var corruptPublicHolidaysFound = false;

for (var calculationYear = startYear; calculationYear < endYear; calculationYear++)
for (var processingYear = startYear; processingYear < endYear; processingYear++)
{
try
var items = HolidaySystem.GetHolidays(processingYear, countryCode);
if (items.Any(o => !o.Date.Year.Equals(processingYear)))
{
var items = HolidaySystem.GetHolidays(calculationYear, countryCode);
if (items.Any(o => !o.Date.Year.Equals(calculationYear)))
{
corruptPublicHolidaysFound = true;
break;
}
}
catch (Exception exception)
{
Debug.WriteLine($"{countryCode} {exception}");
corruptPublicHolidaysFound = true;
break;
}
}

Debug.WriteLineIf(corruptPublicHolidaysFound, $"Check country {countryCode}");

if (corruptPublicHolidaysFound)
{
Assert.Fail($"Check country {countryCode}");
}
}
}


[TestMethod]
public void CheckDuplicateHolidayDefinition()
{
var startYear = DateTime.Today.Year - 100;
var endYear = DateTime.Today.Year + 100;

foreach (CountryCode countryCode in Enum.GetValues(typeof(CountryCode)))
{
for (var calculationYear = startYear; calculationYear < endYear; calculationYear++)
{
var items = HolidaySystem.GetHolidays(calculationYear, countryCode);

var groupedHolidays = items
.GroupBy(o => new { o.Date, o.EnglishName, o.LocalName, o.SubdivisionCodes })
.Select(o => new { o.Key.Date, o.Key.EnglishName, Count = o.Count() });

if (groupedHolidays.Where(o => o.Count > 1).Any())
{
Assert.Fail($"Check country {countryCode}");
}
}
}
}

[TestMethod]
public void CheckIsPublicHoliday()
{
var isPublicHoliday = HolidaySystem.IsPublicHoliday(new DateTime(2016, 5, 1), CountryCode.AT);
Assert.AreEqual(true, isPublicHoliday);
Assert.IsTrue(isPublicHoliday);

isPublicHoliday = HolidaySystem.IsPublicHoliday(new DateTime(2016, 1, 6), CountryCode.AT);
Assert.AreEqual(true, isPublicHoliday);
Assert.IsTrue(isPublicHoliday);

isPublicHoliday = HolidaySystem.IsPublicHoliday(new DateTime(2016, 1, 6), "AT");
Assert.AreEqual(true, isPublicHoliday);
Assert.IsTrue(isPublicHoliday);

isPublicHoliday = HolidaySystem.IsPublicHoliday(new DateTime(2016, 1, 6), "AT");
Assert.AreEqual(true, isPublicHoliday);
Assert.IsTrue(isPublicHoliday);
}

[TestMethod]
Expand All @@ -100,8 +122,10 @@ public void CheckIsOfficialPublicHolidayByCounty1()
{
var isPublicHoliday = HolidaySystem.IsPublicHoliday(new DateTime(2019, 8, 5), CountryCode.AU);
Assert.IsFalse(isPublicHoliday);

isPublicHoliday = HolidaySystem.IsPublicHoliday(new DateTime(2019, 8, 5), CountryCode.AU, "AU-NT");
Assert.IsTrue(isPublicHoliday);

isPublicHoliday = HolidaySystem.IsPublicHoliday(new DateTime(2019, 8, 5), CountryCode.AU, "AU-WA");
Assert.IsFalse(isPublicHoliday);
}
Expand Down
0