8000 bbi.fetch with summary="sum" by keller-mark · Pull Request #12 · nvictus/pybbi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

bbi.fetch with summary="sum" #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 12, 2020
Merged

bbi.fetch with summary="sum" #12

merged 7 commits into from
Jun 12, 2020

Conversation

keller-mark
Copy link
Contributor

This adds a "sum" summary option

@nvictus
Copy link
Owner
nvictus commented Jun 9, 2020

Thanks, Mark! I'm impressed you even went in and adapted the C functions too!

I suspect the test is failing because of the inexact way the UCSC lib does summary statistics by interpolating from the nearest zoom level. You could test by checking the sum of an entire chromosome as 1 bin and by trying a sufficiently high resolution that the original intervals are used to calculate sums.

I suspect that the min and max tests are technically wrong for that reason too, but they happen to work out.

@nvictus nvictus merged commit 0c3ebbf into nvictus:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvictus nvictus nvictus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keller-mark @nvictus
0