8000 Fix definition of controlling and controlled computers being swapped by SaschaCowley · Pull Request #18038 · nvaccess/nvda · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix definition of controlling and controlled computers being swapped #18038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2025

Conversation

SaschaCowley
Copy link
Member

Link to issue number:

https://groups.io/g/nvda-translations/message/4636?p=,,,20,0,0,0

Summary of the issue:

In the user guide section for the Remote Access automatic connection mode, the definitions for "Control another computer" and "Allow this computer to be controlled" were swapped.

Description of user facing changes

  1. The definitions have been swapped, so they are now correctly paired.
  2. "machine" has been replaced with "computer" per Fix up user-facing Remote Access terminology #17943.

Description of development approach

Modify the table in user_docs/en/userGuide.md.

Testing strategy:

Build user documentation and check generated output.

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@SaschaCowley SaschaCowley marked this pull request as ready for review May 2, 2025 01:49
@SaschaCowley SaschaCowley requested a review from a team as a code owner May 2, 2025 01:49
@SaschaCowley SaschaCowley requested a review from Qchristensen May 2, 2025 01:49
@AppVeyorBot
Copy link

See test results for failed build of commit 0444ebfcd9

@seanbudd seanbudd merged commit f83c971 into beta May 4, 2025
4 of 5 checks passed
@seanbudd seanbudd deleted the fixUGLeaderFollower branch May 4, 2025 23:16
@seanbudd seanbudd added this to the 2025.1 milestone May 4, 2025
@github-actions github-actions bot modified the milestones: 2025.1, 2025.2 May 4, 2025
@seanbudd seanbudd modified the milestones: 2025.2, 2025.1 May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0