8000 Updated NSIS to 3.11 by dpy013 · Pull Request #18027 · nvaccess/nvda · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Updated NSIS to 3.11 #18027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Updated NSIS to 3.11 #18027

wants to merge 3 commits into from
+4 −2

Conversation

dpy013
Copy link
Contributor
@dpy013 dpy013 commented Apr 29, 2025 •
edited
Loading

Link to issue number:

nvaccess/NSIS-build#5

Summary of the issue:

Upgrade NSIS from 3.10 to 3.11.
Here are the Release Notes

Description of user facing changes

none

Description of development approach

Updated the NVDA/include/NSIS submodule

Testing strategy:

The scons launcher version=test1 command has been used to locally test the build of the installation package file, and testing in the CI environment is required.

Known issues with pull request:

none

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@dpy013 dpy013 requested a review from a team as a code owner April 29, 2025 06:33
@dpy013 dpy013 requested a review from SaschaCowley April 29, 2025 06:33
@dpy013 dpy013 marked this pull request as draft April 29, 2025 06:35
@dpy013 dpy013 force-pushed the Updated-nsis3.11 branch from 071c1b2 to 61c7944 Compare April 29, 2025 06:52
@dpy013 dpy013 changed the title NSIS3.10to3.11 Updated NSIS to 3.11 Apr 29, 2025
@dpy013 dpy013 marked this pull request as ready for review April 29, 2025 08:39
@AppVeyorBot
Copy link

See test results for failed build of commit 4ba162db4c

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label May 5, 2025
@dpy013 dpy013 force-pushed the Updated-nsis3.11 branch from 6c713be to f846899 Compare May 9, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaCowley SaschaCowley Awaiting requested review from SaschaCowley SaschaCowley is a code owner automatically assigned from nvaccess/developers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpy013 @AppVeyorBot @seanbudd
0