-
-
Notifications
You must be signed in to change notification settings - Fork 679
[BUGFIX] Use the correct combinations for Eurobraille braille displays #18048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[BUGFIX] Use the correct combinations for Eurobraille braille displays #18048
Conversation
See test results for failed build of commit ce85031cbd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is undesirable that we change assignments, especially if users of NVDA have been used to these for ages.
This would be true if users used the NVDA keyboard, but they have always been advised to use the usb-hid keyboard. In addition, when Eurobraille had its own driver, the right commands were present, it was during the implementation of native support for Eurobraille displays that the commands were modified. They themselves asked me if it was possible to modify them. |
Who is they here? Can we get some official communication directly from Eurobraille to NV Access |
I recommend that you read the user manual, here from the B.note braille display, and see the combinations in the penultimate chapter. The user manual is here. |
@theotime2005 - without direct communication from Eurobraille encouraging these changes it is unlikely we will accept this PR |
Link to issue number:
There is no issue associated with this pull request
Summary of the issue:
The purpose of this pull request is to use the official controls of the Eurobraille braille displays. They can be found in the official documentation here.
Description of user facing changes
Users will now be able to use the classic controls of the Eurobraille displays that are indicated in the user manuals and given by the hardware suppliers. This will make it clearer and have less confusion between the controls chosen by Eurobraille and the one chosen by the screen reader.
Description of development approach
Edit the file containing the orders associated with the Eurobraille displays.
Testing strategy:
Code Review Checklist:
@coderabbitai summary