8000 [BUGFIX] Use the correct combinations for Eurobraille braille displays by theotime2005 · Pull Request #18048 · nvaccess/nvda · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BUGFIX] Use the correct combinations for Eurobraille braille displays #18048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

theotime2005
Copy link
@theotime2005 theotime2005 commented May 3, 2025

Link to issue number:

There is no issue associated with this pull request

Summary of the issue:

The purpose of this pull request is to use the official controls of the Eurobraille braille displays. They can be found in the official documentation here.

Description of user facing changes

Users will now be able to use the classic controls of the Eurobraille displays that are indicated in the user manuals and given by the hardware suppliers. This will make it clearer and have less confusion between the controls chosen by Eurobraille and the one chosen by the screen reader.

Description of development approach

Edit the file containing the orders associated with the Eurobraille displays.

Testing strategy:

  • Start NVDA,
  • Connect NVDA to a braille display mades by Eurobraille.
  • Check that the press control key is now with b78 and space key,
  • Check that the press alt key is now with b8 and space key,
  • Check that the press shift key is now with b7 and space key.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@theotime2005 theotime2005 marked this pull request as ready for review May 3, 2025 12:28
@theotime2005 theotime2005 requested a review from a team as a code owner May 3, 2025 12:28
@theotime2005 theotime2005 requested a review from SaschaCowley May 3, 2025 12:28
@OzancanKaratas OzancanKaratas requested a review from LeonarddeR May 3, 2025 12:36
@AppVeyorBot
Copy link

See test results for failed build of commit ce85031cbd

Copy link
Collaborator
@LeonarddeR LeonarddeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is undesirable that we change assignments, especially if users of NVDA have been used to these for ages.

@theotime2005
Copy link
Author

I think it is undesirable that we change assignments, especially if users of NVDA have been used to these for ages.

This would be true if users used the NVDA keyboard, but they have always been advised to use the usb-hid keyboard. In addition, when Eurobraille had its own driver, the right commands were present, it was during the implementation of native support for Eurobraille displays that the commands were modified. They themselves asked me if it was possible to modify them.

@seanbudd
Copy link
Member
seanbudd commented May 5, 2025

They themselves asked me if it was possible to modify them.

Who is they here? Can we get some official communication directly from Eurobraille to NV Access

@seanbudd seanbudd added the blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases. label May 5, 2025
@theotime2005
Copy link
Author

They themselves asked me if it was possible to modify them.

Who is they here? Can we get some official communication directly from Eurobraille to NV Access

I recommend that you read the user manual, here from the B.note braille display, and see the combinations in the penultimate chapter. The user manual is here.

@seanbudd
Copy link
Member
seanbudd commented May 6, 2025

@theotime2005 - without direct communication from Eurobraille encouraging these changes it is unlikely we will accept this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
@theotime2005 @AppVeyorBot @seanbudd < 333B a class="participant-avatar" data-hovercard-type="user" data-hovercard-url="/users/LeonarddeR/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/LeonarddeR"> @LeonarddeR
0