-
-
Notifications
You must be signed in to change notification settings - Fork 699
Update ruff, pyright, pre-commit, add-trailing-comma #17671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dde09d7
to
cc2bbd3
Compare
See test results for failed build of commit fe02c544cb |
Looks like we need to do another big automated lint - new Ruff rules! |
616a43a
to
22bf6d6
Compare
See test results for failed build of commit 7f5eba6422 |
739e9e9
to
c17fda3
Compare
4df9213
to
3756a80
Compare
274a245
to
6383adb
Compare
I really don't like the way ruff auto formats multi-line strings. I've opened this issue astral-sh/ruff#18436 as an example |
f75c657
to
1d74418
Compare
seanbudd
reviewed
Jun 3, 2025
add string concat reference
seanbudd
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
conceptApproved
Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates for linting:
updates for pre-commit:
Merge as merge commit, to preserve the reference in
.git-blame-ignore-revs