8000 perf(nuxt)!: use component loader to add meta components by harlan-zw · Pull Request #8167 · nuxt/framework · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

perf(nuxt)!: use component loader to add meta components #8167

Merged
merged 3 commits into from
Oct 13, 2022
Merged

perf(nuxt)!: use component loader to add meta components #8167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52ad910
fix(nuxt): on-demand head components
harlan-zw Oct 13, 2022
2606acf
chore: useAddComponent
harlan-zw Oct 13, 2022
4cca10a
refactor: extract component names
danielroe Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions packages/nuxt/src/head/module.ts
View file
Open in desktop
8000
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import { resolve } from 'pathe'
import { addPlugin, defineNuxtModule } from '@nuxt/kit'
import { addComponent, addPlugin, defineNuxtModule } from '@nuxt/kit'
import { distDir } from '../dirs'

const components = ['Script', 'NoScript', 'Link', 'Base', 'Title', 'Meta', 'Style', 'Head', 'Html', 'Body']

export default defineNuxtModule({
meta: {
name: 'meta'
Expand All @@ -15,8 +17,20 @@ export default defineNuxtModule({
// Add #head alias
nuxt.options.alias['#head'] = runtimeDir

// Add generic plugin
addPlugin({ src: resolve(runtimeDir, 'plugin') })
// Register components
const componentsPath = resolve(runtimeDir, 'components')
for (const componentName of components) {
addComponent({
name: componentName,
filePath: componentsPath,
export: componentName,
// kebab case version of these tags is not valid
kebabName: componentName
})
}

// Add mixin plugin
addPlugin({ src: resolve(runtimeDir, 'mixin-plugin') })

// Add library specific plugin
addPlugin({ src: resolve(runtimeDir, 'lib/vueuse-head.plugin') })
Expand Down
11 changes: 0 additions & 11 deletions packages/nuxt/src/head/runtime/plugin.ts → ...ges/nuxt/src/head/runtime/mixin-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,7 @@
import { getCurrentInstance } from 'vue'
import * as Components from './components'
import { useHead } from './composables'
import { defineNuxtPlugin, useNuxtApp } from '#app'

type MetaComponents = typeof Components
declare module '@vue/runtime-core' {
export interface GlobalComponents extends MetaComponents {}
}

const metaMixin = {
created () {
const instance = getCurrentInstance()
Expand All @@ -27,9 +21,4 @@ const metaMixin = {

export default defineNuxtPlugin((nuxtApp) => {
nuxtApp.vueApp.mixin(metaMixin)

for (const name in Components) {
// eslint-disable-next-line import/namespace
nuxtApp.vueApp.component(name, (Components as any)[name])
}
})
0