fix: add support for nested CSS #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b5506a to
4f4c8f6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
==========================================
+ Coverage 83.85% 83.96% +0.10%
==========================================
Files 13 13
Lines 1016 1029 +13
Branches 266 271 +5
==========================================
+ Hits 852 864 +12
- Misses 158 159 +1
Partials 6 6 ☔ View full report in Codecov by Sentry. |
danielroe
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Thank you - this looks great!
This will soon be coming natively to csstree - see csstree/csstree#268 (comment) after which we can remove this, but your solution should gracefully fall back as it will then no longer emit Raw nodes.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #371
❓ Type of change
📚 Description
Adds support for nested CSS when the module parses CSS.
I don't want to create a lot of tests, so the test I have added is minimal but covers different nested CSS situations