refactor!: migrate to unifont
#315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying fonts with
|
| Latest commit: |
0bd1d87
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d8a8db9f.fonts-dsw.pages.dev |
| Branch Preview URL: | https://feat-unifont.fonts-dsw.pages.dev |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
==========================================
- Coverage 42.20% 32.33% -9.88%
==========================================
Files 58 52 -6
Lines 3561 2991 -570
Branches 450 305 -145
==========================================
- Hits 1503 967 -536
+ Misses 2020 1985 -35
- Partials 38 39 +1 ☔ View full report in Codecov by Sentry. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
this extracts font providers to https://github.com/unjs/unifont where they can be tested/improved separately from
nuxt/fontsitself.It's already flagged up a few issues which have been resolved in
unifont.We have backwards compatibility for now with previous custom font provider format via an internal
toUnifontProviderbut this will be eventually removed before v1 release of@nuxt/fonts.🚧 TODO: