8000 fix: only overwrite `cacheDir` after a fresh build by danielroe · Pull Request #273 · nuxt/fonts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: only overwrite cacheDir after a fresh build #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix: only overwrite cacheDir after a fresh build #273

merged 1 commit into from
Sep 23, 2024

Conversation

danielroe
Copy link
Member
@danielroe danielroe commented Sep 23, 2024 •
edited
Loading

resolves #266

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

this adds support for experimental.buildCache - otherwise the cache directory was being erased before the nitro build - with no information on what fonts to insert into it

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying fonts with  Cloudflare Pages  Cloudflare Pages

Latest commit: 54fecf0
Status: ✅  Deploy successful!
Preview URL: https://eec38a93.fonts-dsw.pages.dev
Branch Preview URL: https://fix-build-cache.fonts-dsw.pages.dev

View logs

8000 @danielroe danielroe merged commit 8048fb5 into main Sep 23, 2024
2 checks passed
@danielroe danielroe deleted the fix/build-cache branch September 23, 2024 14:18
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.46%. Comparing base (0fb0157) to head (54fecf0).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
+ Coverage   41.43%   41.46%   +0.03%     
==========================================
  Files          58       58              
  Lines        3538     3540       +2     
  Branches      436      437       +1     
==========================================
+ Hits         1466     1468       +2     
  Misses       2034     2034              
  Partials       38       38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Sep 23, 2024
Closed
Closed
@peralta
Copy link
peralta commented Sep 24, 2024 •
edited
Loading

Was this issue completed? I cannot find the experimental.buildCache in the config options.
After upgrading to v0.9.0, fonts are not being deployed to my netlify deployment (_fonts/ path is simply not part of the deployed files). Behaviour persists in v0.9.1 and used to work with v0.8.0. I think this PR is a probable culprit.

@danielroe
Copy link
Member Author

@peralta would you open a new issue with a reproduction? 🙏

@peralta
Copy link
peralta commented Sep 24, 2024

Will do. Although I can describe the project setup that is having the issue, I don't know if I will manage to get a clear reproduction (as in a Stackblitz).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support for nuxt experimental.buildCache
3 participants
@danielroe @codecov-commenter @peralta
0