8000 feat(`processCSSVariables`): add `font-prefixed-only` option by qwerzl · Pull Request #515 · nuxt/fonts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(processCSSVariables): add font-prefixed-only option #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 8, 2025
Merged

feat(processCSSVariables): add font-prefixed-only option #515

merged 8 commits into from
Mar 8, 2025

Conversation

qwerzl
Copy link
Member
@qwerzl qwerzl commented Feb 20, 2025

🔗 Linked issue

Related to #468

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR adds a font-prefixed-only option to experimental.processCSSVariables to only process variables starting with --font as Tailwind v4 and Unocss-preset-next are now both utilizing variables followed by this pattern. This would solve some performance issues introduced by processing all the CSS variables.

I also propose to move processCSSVariables out of experimental and make it default to font-prefixed-only.

@qwerzl qwerzl requested a review from danielroe as a code owner February 20, 2025 08:08
@qwerzl qwerzl mentioned this pull request Feb 20, 2025
Closed
6 tasks
@codecov-commenter
Copy link
codecov-commenter commented Feb 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.48%. Comparing base (f751d40) to head (01a7f68).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
+ Coverage   82.84%   83.48%   +0.63%     
==========================================
  Files          13       13              
  Lines        1067     1072       +5     
  Branches      264      271       +7     
==========================================
+ Hits          884      895      +11     
+ Misses        178      172       -6     
  Partials        5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@qwerzl qwerzl marked this pull request as draft February 20, 2025 08:39
@danielroe
Copy link
Member

Sounds good to me! We can enable by default + move out of experimental 👍

@qwerzl qwerzl marked this pull request as ready for review February 21, 2025 03:29
@qwerzl
Copy link
Member Author
qwerzl commented Feb 21, 2025

@danielroe This PR is ready for review. I've also added the tests.

@danielroe danielroe merged commit a478bf4 into nuxt:main Mar 8, 2025
2 checks passed
@github-actions github-actions bot mentioned this pull request Mar 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qwerzl @codecov-commenter @danielroe
0