fix: enable cycles option when stringifying objects #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for nuxt-storybook pending review.Visit the deploys page to approve it
|
tobiasdiez
approved these changes
May 9, 2025
There was a problem hiding this comment.
Thanks!
The failing test seems to be unrelated (and happens on other recent PRs as well - not sure why).
@chakAs3 what do you think about cutting a new release?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #817
📚 Description
Without replacing the
json-stable-stringifydependency, we can simply enablecyclesto properlystringifyobjects with circular references as the nuxt config object can have.