8000 Android socket implementation by kylelwm · Pull Request #58 · nus-mtp/worldscope · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Android socket implementation #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Mar 1, 2016
Merged

Android socket implementation #58

merged 20 commits into from
Mar 1, 2016

Conversation

kylelwm
Copy link
Contributor
@kylelwm kylelwm commented Mar 1, 2016

Added Socket.IO functionality
Emit events such as 'identify' and 'join'
Refactored LoginActivity to reduce coupling and creating a social media wrapper
Refactored ViewActivity to change ExoPlayer into a fragment
Remove some magic strings
Implemented a UI for comments
and...minor bug fixes

kylelwm added 20 commits March 1, 2016 22:29
@kylelwm
Refactor magic strings and change video format to MP4
9be16c2
@kylelwm
Renamed FacebookLoginActivity and its test to just LoginActivity and …
d254205 
…LoginActivityTest
@kylelwm
Refactor the name FacebookLoginActivity to LoginActivity
f563e30
@kylelwm
Updated manifest to point to LoginActivity as default activity
50036d2
@kylelwm
Created abstraction for social media where Facebook is one of the ins…
b0675bd 
…tances
@kylelwm
Created instance of social media wrapper called Facebook Wrapper
88a6055
@kylelwm
Remove references to Facebook and instead replace with the wrappers
e0e8550
@kylelwm
Assets for sent button
a5c0ea8
@kylelwm
Refactor classes into more suitable packages
daf8216
@kylelwm
Renamed XML to better reflect them as XML for fragments
03d685d
@kylelwm
Refactored to reflect as fragment XML
80b1f47
@kylelwm
Refactored to reflect XML as Activity's XML
39ddb8b
@kylelwm
Remove reliance on intents to get user, instead, user is now retrieve…
d1ae6aa 
…d from WorldScopeAPIService
@kylelwm
Make WorldScopeCreatedStream model parcelable
a134980
@kylelwm
Added socket services for WorldScope using Socket.IO
00076a4
@kylelwm
Make calls to Socket.IO for identification and joining rooms
c4b1d08
@kylelwm
Added default empty constructor to appease Android Studio IDE
b3f9e07
@kylelwm
Included Socket.IO as a dependency
25440fc
@kylelwm
Refactored the Exoplayer into a fragment from the ViewActivity
ef82c35
@kylelwm
Implemented and added basic UI for comments
971b323
@kylelwm kylelwm assigned kylelwm and sharminelow and unassigned kylelwm Mar 1, 2016
@sharminelow
Copy link
Contributor

Good refactoring in place. Ready to merge.

kylelwm added a commit that referenced this pull request Mar 1, 2016
@kylelwm
Merge pull request #58 from nus-mtp/android-socket-implementation
46a1239 
Android socket implementation
@kylelwm kylelwm merged commit 46a1239 into master Mar 1, 2016
@kylelwm kylelwm deleted the android-socket-implementation branch March 1, 2016 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sharminelow sharminelow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylelwm @sharminelow
0