Feature/lfo phase #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cale-bradbury
approved these changes
Sep 8, 2018
|
Thanks for taking a look. Already fixed the other issue, you can now double click on any slidey thing. :) |
7EC0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LFO phase. Use 0.25 for cosine. Made a simple little trig example project, worth checking that out to see it all in action. @netgrind can you look over this and see if you think it all makes sense? I feel it's all good for sine/triangle/square. Not sure about the sawtooth ones?
Note: At the moment it's a bit annoying if you want to get an exact value (e.g. 0.25, 0.5), I'm fixing this separately. (#89)