optional destructor function in sketch gets called upon deletion, use… #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ful if there is anything that needs to be cleaned up
|
This looks good, nice idea. This is also a good example of why the docs need to be part of the source code, so changes like this can also come with some docs changes. I'm sure it all works fine but I'm yet to test it my end, will try and find the time to do this weekend. I might write a little test for it too. :) |
|
hmm, I couldn't really figure out how to do a pull request on the wiki :/ edit: forgot link https://github.com/netgrind/hedron/wiki/Creating-Sketches |
|
Merged, docs still need updating, captured in separate issue: #45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ful if there is anything that needs to be cleaned up
I use this for post effects, and a video player (adds a hidden video element to the dom in order to get a THREE.VideoTexture)