8000 Fix/value types refactor by funwithtriangles · Pull Request #323 · nudibranchrecords/hedron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix/value types refactor #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Nov 7, 2019
Merged

Fix/value types refactor #323

merged 21 commits into from
Nov 7, 2019

Conversation

funwithtriangles
Copy link
Member

Refactored how value types work (e.g. floats, booleans, enums). They now all live in one place, and adding a new one should be as easy as adding one in that one place without having to go through the code to do all of the little things to get it to work.

This also means we now have enums as a value type, as we already had select boxes and it wasn't much work to rework this into a value type, woo!

Fixes #322
Fixes #185

@funwithtriangles
Refactored param/shot generation from config (allows for no title in …
fa69216 
…shots, uses method name as default)
@funwithtriangles
Moved logic for types into one place (not all logic yet)
138c13f
@funwithtriangles
Fixed bug with redux form not parsing numbers
f31e4b2
@funwithtriangles
Defining compatibleInputs for valueType
f909f0c
@funwithtriangles
valueType can define extra options for inputs
7ac4d2c
@funwithtriangles
lifecycle methods for value types
ceb79d6
@funwithtriangles
Organised valueTypes into separate files
037b63e
@funwithtriangles
valueProcess functions defined in valueTypes
199ad57
@funwithtriangles
Improved how extra input options are generated for valueTypes
a0bfdaf
@funwithtriangles
Moved more input logic ino valueType lifecycle methods, converted sag…
bf45135 
…a to listener
@funwithtriangles
Added sequencer functionality to boolean valueType
927a83c
@funwithtriangles
Test fixes
16863ba
@funwithtriangles
valueType now defines Component
55c84e9
@funwithtriangles
enum valueType
f7bb1ae
@funwithtriangles
Custom config for value types
328077e
@funwithtriangles
Moved compoinent files to related valueType directories
177ca9a
@funwithtriangles
AdvancedControlComponent option for value types
97c2e67
@funwithtriangles
8000 Console log error if valueType isnt recognised in the config
0b60b9f
@funwithtriangles
Updated example sketch to use enums, along with documentation
cb25f62
@funwithtriangles
noteOn increments through enum options
5a25950
@funwithtriangles funwithtriangles added this to the 0.6.0 milestone Nov 6, 2019
@funwithtriangles funwithtriangles mentioned this pull request Nov 7, 2019
Closed
@funwithtriangles funwithtriangles merged commit db51dbb into dev Nov 7, 2019
@funwithtriangles funwithtriangles deleted the fix/value-types-refactor branch November 7, 2019 14:24
This was referenced Nov 7, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Changing min/max for param in "advanced" doesn't work Boolean param type
1 participant
@funwithtriangles
0