8000 Fix/method args by funwithtriangles · Pull Request #340 · nudibranchrecords/hedron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix/method args #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 14, 2020
Merged

Fix/method args #340

merged 4 commits into from
Jan 14, 2020

Conversation

funwithtriangles
Copy link
Member

Clean up around arguments for sketch methods. Now all of them use a single object. Also cleaned up the timing values that are passed to update.

Also improved the docs a bit. :)

Fixes #269
Fixes #268

@funwithtriangles funwithtriangles merged commit a2504f1 into dev Jan 14, 2020
@funwithtriangles funwithtriangles deleted the fix/method-args branch January 14, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider using objects instead of arguments for sketch methods and constructor Add delta and time to update method arguments
1 participant
@funwithtriangles
0