fix(types): nullable relations are never undefined #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
254c11f to
66c1248
Compare
It is not possible for the value of nullable relations to be undefined: if the relation does not have an initial value during creation it defaults to null and it is not possible to update the value to be undefined.
66c1248 to
bedfe4c
Compare
kettanaito
approved these changes
Dec 18, 2021
There was a problem hiding this comment.
Thank you for spotting this, @olivierwilkinson! A great fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake when updating #158 after we merged #143, it is not actually possible for nullable relationships to be
undefined, they arenullinstead. Sorry I let that slip by!This is purely for proper annotation similarly to #158
It is not possible for the value of nullable relations to be undefined because: