Add additional multipart headers as an optional parameter #183

deathgrindfreak · 2018-10-15T18:07:26Z

As we talked about previously, this commit adds any additional multipart headers as an optional record type parameter.

mscdex · 2018-10-15T18:24:21Z

lib/types/multipart.js

@@ -258,7 +265,9 @@ function Multipart(boy, cfg) {
          curField = undefined;
          if (buffer.length)
            buffer = decodeText(buffer, 'binary', charset);
-          boy.emit('field', fieldname, buffer, false, truncated, encoding, contype);
+
+          var hdrs = Object.keys(additionalHeaders).length ? additionalHeaders : null;


We can either use a simple boolean that is set in the for loop to avoid Object.keys() or we could just always pass additionalHeaders. I'm fine with either way.

Or we could just pass header as-is. That would save us from having to do any additional work.

Yeah, an empty object might be nice there, since it would avoid two null checks I suppose. I think I'll just pass in the object if that's cool with you.

mscdex · 2018-10-16T06:32:36Z

lib/types/multipart.js

@@ -169,6 +170,10 @@ function Multipart(boy, cfg) {
      else
        encoding = '7bit';

+      for (var h in header) {


I think we should just iterate over Object.keys(header) to avoid traversing prototypes and the like.

mscdex · 2018-10-16T06:35:58Z

@@ -169,6 +170,10 @@ function Multipart(boy, cfg) {
      else
        encoding = '7bit';

+      for (var h in header) {
+        if (!isRequiredHeader(h)) additionalHeaders[h] = header[h][0];


I think we should not be forcing the first value all the time, in case someone is interested in seeing all of the duplicate header values. Maybe at the very least we could just return the first value if header[h].length === 1 otherwise use the array value. Also just always assigning to header[h] so it's always an array for consistency is fine by me too.

…e first

deathgrindfreak · 2018-10-17T01:13:20Z

Sounds good to me, added the changes in the above commit.

deathgrindfreak · 2018-11-12T16:42:06Z

Any idea if this will be merged any time in the future?

codeimmortal · 2019-06-04T07:15:05Z

@mscdex any update to add this additional header feature

Martin-Luther · 2020-03-19T10:44:18Z

Hello guys,
First of all, thanks for your amazing work.
I was wondering: why not emitting an object with all properties at once: both required and additional properties (headers) ?

If not, when Cooper's changes will be merged with the master ?

deathgrindfreak added 2 commits October 15, 2018 12:54

Add additional multipart headers as an optional parameter

fb86698

mscdex reviewed Oct 15, 2018

View reviewed changes

Always pass in additional headers object

b4e29f2

mscdex reviewed Oct 16, 2018

View reviewed changes

deathgrindfreak added 2 commits October 16, 2018 20:08

Iterate over Object.keys of header, add all header values not just th…

e67f154

…e first

Node 0.10 doesn't support "for of", replace with forEach

99d6436

mscdex added the feature request label Dec 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add additional multipart headers as an optional parameter #183

Add additional multipart headers as an optional parameter #183

Add additional multipart headers as an optional parameter #183

Are you sure you want to change the base?

Add additional multipart headers as an optional parameter #183

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment