Tags: mrliao/hhvm
Tags
EZC: Fix count() and conversion to boolean of ProxyArray Fix JIT versions of count() and conversion of array to boolean, so that they work with ProxyArray. In both cases, duplicate the logic in ArrayData::size() -- if the sign bit of the size field is unset, use that field, otherwise call vsize(). The resulting generated machine code for conversion to boolean is along the lines of: mov 0x4(%rdi),%eax test %eax,%eax js 0xf80049b setne %al where 0xf80049b is the slow path. This is similar to the machine code I previously reported for ArrayData::size() in code review of 1717e028f18 (see facebook#3065). Added test case which previously failed.
stop breaking ubuntu 10.04 Summary: A partial revert of facebook#3591 . I used `FindLibZip.cmake` as a template. I think for system defined libraries the old code was good enough, but if the thing is only installed in the CMAKE_INCLUDE_PATH then the macro@radford was using won't work. Reviewed By: @JoelMarcey Differential Revision: D1560119
unit tests expected output fix for change in object destruction order Summary: Fi unit tests expected output Reviewed By: mwilliams Subscribers: hphp-diffslists, ps
Don't build test binary by default. Enable it with `cmake -DTEST_BIN=On .`
Revert "Properly invoke setter/getter for unset declared properties" This reverts commit 2638538.
PreviousNext