Support for sums over arrays #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weshinsley
approved these changes
Sep 17, 2024
vignettes/errors.Rmd
Outdated
| @@ -399,6 +399,58 @@ a <- parameter(type = "integer", differentiate = TRUE) | |||
|
|
|||
| Here, you must decide if `a` should be differentiable (in which case remove the `type` argument) or an integer (in which case remove the `differentiate` argument). | |||
|
|
|||
| # `E1033` | |||
|
|
|||
| The argument to sum must be an array. This can either be a complete array (in which case the argument will be a symbol). So this is fine: | |||
There was a problem hiding this comment.
Need something connected with the "either" - maybe "or a partial array, by summing across one or more dimensions"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for support for sums - both complete and partial - using C++ functions I've added into dust in mrc-ide/dust2#71
The syntax is identical to that in odin1 and I've added a few notes into the functions vignette to explain the idea.
Very little is required here for prod (mrc-ide/odin#316) but I'd like to do that separately once we're a bit further along.
Update branch pin after merging dust2