8000 [MANA-37] Add version tracking to MANA by fyshhh · Pull Request #45 · mpickpt/mana · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[MANA-37] Add version tracking to MANA #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master-old
Choose a base branch
from
Open

[MANA-37] Add version tracking to MANA #45

wants to merge 3 commits into from

Conversation

fyshhh
Copy link
Collaborator
@fyshhh fyshhh commented Jan 5, 2022 •
edited
Loading

This pull request adds version tracking to MANA, organized similarly to how criu does. More information can be added to Makefile.versions as necessary in the future.

@fyshhh fyshhh requested review from gc00, JainTwinkle and jungan January 5, 2022 21:04
@fyshhh fyshhh self-assigned this Jan 5, 2022
jungan
jungan reviewed Jan 6, 2022
View reviewed changes
Copy link
Collaborator
@jungan jungan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you add the git commit hash id?

We probably also want to add a cmdline option to those binaries, so something like dmtcp_coordinator --version will print the version number.

BTW, you should submit PR to master, this change is not related to CentOS, rebase your local branch on top of master, and then submit PR to master.

@JainTwinkle
Copy link
Collaborator
JainTwinkle commented Jan 6, 2022 •
edited
Loading

Is the intention to keep track of both DMTCP's version and MANA's version? If so then should we rename the header file as mana-version.h? because the root directory of MANA has a VERSION file that points to DMTCP's version. In addition
, MANA's README.md should be updated stating how to get either version's information.

@fyshhh fyshhh changed the base branch from feature/centos to master January 7, 2022 18:33
@fyshhh
Copy link
Collaborator Author
fyshhh commented Jan 7, 2022

Is the intention to keep track of both DMTCP's version and MANA's version? If so then should we rename the header file as mana-version.h? because the root directory of MANA has a VERSION file that points to DMTCP's version. In addition , MANA's README.md should be updated stating how to get either version's information.

yes, i think we are starting to track MANA's version, the same way criu tracks theirs. i think it would be ideal to merge both version files, just to have one centralized one that keeps track of all the versions of relevant packages. while we discuss whether this is viable, renaming it to mana-version.h is a good stop-gap.

@fyshhh fyshhh force-pushed the track_version branch 2 times, most recently from c664b53 to 6202729 Compare January 7, 2022 22:20
@memverge-bot
Copy link
Collaborator

test this please

1 similar comment
@fyshhh
Copy link
Collaborator Author
fyshhh commented < 8000 a href="#issuecomment-1013542767" id="issuecomment-1013542767-permalink" class="Link--secondary js-timestamp">Jan 14, 2022

test this please

@fyshhh fyshhh force-pushed the track_version branch 2 times, most recently from 6537221 to 652e635 Compare January 20, 2022 05:47
@jungan
Copy link
Collaborator
jungan commented Jan 24, 2022

Is the intention to keep track of both DMTCP's version and MANA's version? If so then should we rename the header file as mana-version.h? because the root directory of MANA has a VERSION file that points to DMTCP's version. In addition , MANA's README.md should be updated stating how to get either version's information.

yes, i think we are starting to track MANA's version, the same way criu tracks theirs. i think it would be ideal to merge both version files, just to have one centralized one that keeps track of all the versions of relevant packages. while we discuss whether this is viable, renaming it to mana-version.h is a good stop-gap.

I don't think we want to merge both versions, to my understanding, MANA is built on top of DMTCP, but they could dev&release separately. MANA should have its own version. (Each MANA version might be on top of a different DMTCP version though)

I also agree with @JainTwinkle that we should update the READ.me file on how to get the MANA version. We should add command-line option to mana_coordinater and/or other binary tools.

@gc00
Copy link
Collaborator
gc00 commented Mar 22, 2022

I agree with the points by @jungan.

  1. MANA is built on top of DMTCP, but they could dev&release separately. MANA should have its own version. (Each MANA version might be on top of a different DMTCP version though)
  2. I also agree with @JainTwinkle that we should update the READ.me file on how to get the MANA version. We should add command-line option to mana_coordinater and/or other binary tools. (Now that we have a well-developed manpages/mana.latex2man file, perhaps you could add getting the MANA version to that file. mana.1 is built from mana.latex2man.)

Since @jungan has been tracking this PR, I'll let @jungan take the lead on reviewing it.

@fyshhh fyshhh force-pushed the track_version branch 2 times, most recently from 81e306a to 2e7e83e Compare March 28, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jungan jungan jungan left review comments

@gc00 gc00 Awaiting requested review from gc00

@JainTwinkle JainTwinkle Awaiting requested review from JainTwinkle

At least 1 approving review is required to merge this pull request.

Assignees

@fyshhh fyshhh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fyshhh @JainTwinkle @memverge-bot @jungan @gc00
0