This repository was archived by the owner on Apr 21, 2023. It is now read-only.
Check version in Attention Stream before sending new data #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rally-prod canceled.
|
✅ Deploy Preview for rally-staging canceled.
|
thomik-corp
reviewed
Sep 15, 2022
| @@ -267,16 +271,10 @@ export class Rally { | |||
|
|
|||
| const data = userStudiesDoc.data(); | |||
|
|
|||
| if (data.enrolled && this._state !== RunStates.Running) { | |||
| if (data.enrolled) { | |||
There was a problem hiding this comment.
Why did we remove running check here?
There was a problem hiding this comment.
Hm, yeah I agree, this was preventing resume() from being called if the extension was already running. We might want to consider moving to a proper state machine that checks this vs. doing it ad-hoc like this.
There was a problem hiding this comment.
resume() already has this same check in it's implementation, so I figured it was redundant.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #204