Default themes #111
Default themes #111
Conversation
|
You are a star. :) Very nicely done @davidlatwe. I really like the new code font. My one critique would be the shade of that light theme.
I personally would prefer the "Before", as the new light seems a bit.. dull? My next critique would be the button shape/shading.
They lost the outline, which I think helps distinguish them from the background and justifies that empty space between the buttons a little better. The same applies to the dock title bar, in both light and dark themes.
I think I'm generally in favour of a more "3d" look than the more "modern" flat look, what do you think? |
|
Thanks @mottosso ! So here's the a bit improved. I guess the ..dull feel on light theme, might be because the background is much grayer and a bit yellowish then the original. So I have bump up a little bit. (can't bump it too white, need to leave some space for brighter color making contrast) From left to right : original -> previous -> latest And here's the quick view of new header buttons being toggled, and the improved dock title (I guess that's the 3d what you were saying ? dark border + little margin) |
|
I still feel we could push further to the color scheme of the original. That "dim grey" just looks like my brightness of my screen is off a bit. It's already much better but still slightly has that old-school feeling.
Is this really crucial to the theme? To me the layout seemed readable in the original too, even cleaner than the new "dim grey" latest version. |
Yep! That's it. I like it much better, what do you think?
I'm with Roy, I would prefer we keep it full white like in the current version, and leave any darkening to the dark theme. |
|
Here it is ! Brightest theme 🚀 current master branch <-> latest light theme
I like the new dock title as well. :D
Well, kind of. Or should say this is the exact down side of using one template style-sheet to compose all styles I think. Since in order to keep the color keywords as few as possible, and keeping push-buttons or combo-box to be separated from the background at the same time, it became like a mono tone styling when making dark/light theme. And changing the template itself means other color styles would be affected as well. Especially for dark/light theme since their color gradient direction must be reversed to each other, and a template could have only one setup. So they may not easily coexists in the same template and works for all. Should have thought about this. :( Still, let me know what you think about this new light theme ! P.S. nice to see you here @BigRoy 👋🏼 |
|
I like it, but if I was picky then there's just a few more things that stand out to me. Outline 1
I think these are important to highlight that they are clickable. In case of the Launch button, also helps pull the eye in that direction, and ground the interface towards its most important aspect; actually launching something. Outline 2 This outline is too bright/strong, demands too much attention. Could we make it either disappear, or the same color as the outline of the tabs? Color Could we keep the original blue for highlights? I dunno, that turquoise makes me thing there's something wrong with the color balance of my display, but I understand this is rather subjective! :D
I've been down this road as well and know what you mean. Have you considered letting the user add not just color, but full |
|
Improvement & fix : Refactored
Implementation of custom themes loadingTheme stylesheet parsing and selecting logic is implemented in # allzparkconfig.py
def themes():
"""Allzpark GUI theme list provider
This will only be called once on startup.
Each theme in list is a dict object, for example:
{
"name": "theme_name",
"source": "my_style.css",
"keywords": {"base-tone": "red", "res": "path-to-icons"},
}
* `name` is the theme name, this is required.
* `source` can be a file path or plain css code, this is required.
* `keywords` is optional, must be dict type if provided, will be
used to string format the css code.
Returns:
list
"""
return []And in "Preference" page, in "Appearance" (previously "Theme") section have a drop-down list for user to select and change between all current loaded themes from The This should be enough to close #82. |
|
Ouch, forgot to mention that in commit 5569df7, I updated The reason for that change was because the
To workaround that, I need the function But |
|
Changing custom theme (Avalon style) in live action ! # allzparkconfig.py
def themes():
from avalon import style
return [
{
"name": "avalon",
"source": style.load_stylesheet(),
}
] |
|
Merging this today :) |
This PR
Implement Theme #14 and User Themes #82
For User Themes #82 however, the implementation isn't exact the same, it's much simplified, see details below.
Fix QTextEdit not rendering
$nbspcorrectly with Windows' default font face #105Two fonts vendorized,
OpenSansandJetBrainsMonoHere's the result :
Outdated info, see comments below
Custom Theme With Palettes
The
style.csshas been changed to be able to format with color codes by keywords, e.g.And multiple color codes can be provided from an attribute named
palettesin user'sallzparkconfig.py, like this :Next Step
Add palette editor next to the current CSS editor, so user can spin the color wheels in there to test the theme in live action. Once done, press a button to save the palette in a.jsonfile next to the preference.inifile.Load style-sheet from
allzparkconfig.py. This will ignore the defaultstyle.csscompletely, so the themepalettesin preference will be disabled.