8000 feat(2d): modifies to match exact strings when passed a plain string by henriqueinonhe · Pull Request #1153 · motion-canvas/motion-canvas · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(2d): modifies to match exact strings when passed a plain string #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2025
Merged

feat(2d): modifies to match exact strings when passed a plain string #1153

merged 1 commit into from
Feb 10, 2025

Conversation

henriqueinonhe
Copy link
Contributor

DRAFT

An attempt at #1035.

@aarthificial
Copy link
Contributor
aarthificial commented Feb 8, 2025 •
edited
Loading

Thanks for the PR!
The logic looks good, not sure about the -3000 lines of code in package.lock.json though. Do you know why it may be?

Did you install the package using workspaces?

npm i <packagename> -w packages/2d

@henriqueinonhe henriqueinonhe force-pushed the allow-matching-substrings-instead-of-patterns branch from 876c17f to 458a061 Compare February 9, 2025 19:31
@henriqueinonhe
Copy link
Contributor Author

Thanks for the PR! The logic looks good, not sure about the -3000 lines of code in package.lock.json though. Do you know why it may be?

Did you install the package using workspaces?

npm i <packagename> -w packages/2d

🤦 Forgot to scope the install to the specific workspace, thanks for the reminder!

@henriqueinonhe henriqueinonhe marked this pull request as ready for review February 9, 2025 19:35
@henriqueinonhe
Copy link
Contributor Author

Question, are there other places where we should update the documentation that you know of from the top of your head? Asking because this is a breaking change and maybe we should include some sort of warning?

@aarthificial aarthificial merged commit 2eb64a4 into motion-canvas:main Feb 10, 2025
7 checks passed
@aarthificial
Copy link
Contributor

Thanks for the fix!
Like I mentioned in #1035, this was never meant to be a feature and so it is not documented anywhere. Our examples in doc use strings for exact string matching and regexes for regex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarthificial aarthificial aarthificial left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henriqueinonhe @aarthificial
0