Remove recursion from collapse
#796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collapse
collapsecollapse
|
Not sure why this build is failing for version 3.8. Does anyone have any suggestions on how to get this fixed? Thx! |
|
@james-wasson Looks like the build is failing on the |
|
I'd rather have a non-recursive algorithm, so once this passes checks I'll merge it! Thanks for the PR. |
|
All checks passed locally. |
|
For reference from more_itertools import collapse, consume
iterable = ['ab', ('cd', [(1, 2), ([3, [(1, 2), ([3, 4], [[5], [6]])]], [[5], [6]])]), ['gh', 'ij'], [(1, [(1, 2), ([3, 4], [[5], [6]])])]]
%timeit -n 100000 consume(collapse(iterable)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue reference
#799
Changes
Change collapse to remove the recursion resulting in noticeable speedup.
Before:
After: