10000 os.Exit for TestMain by nejisama · Pull Request #1143 · mosn/mosn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

os.Exit for TestMain #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2020
Merged

os.Exit for TestMain #1143

merged 2 commits into from
Apr 28, 2020

Conversation

nejisama
Copy link
Contributor

Issues associated with this PR

Your PR should present related issues you want to solve.

Solutions

You should show your solutions about the issues in your PR, including the overall solutions, details and the changes. At this time, Chinese is allowed to describe these.

UT result

Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.

Benchmark

If your code involves the processing of every request, you should give the Benchmark Result.

Code Style

  • Make sure Goimports has run
  • Show Golint result

@taoyuanyuan taoyuanyuan self-requested a review April 28, 2020 11:01
taoyuanyuan
taoyuanyuan approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor
@taoyuanyuan taoyuanyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taoyuanyuan taoyuanyuan merged commit c9218dc into mosn:master Apr 28, 2020
@weekly-digest weekly-digest bot mentioned this pull request May 1, 2020
Closed
@nejisama nejisama deleted the fix/test_main_failed branch May 12, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoyuanyuan taoyuanyuan taoyuanyuan approved these changes

Assignees
No one assigned
Labels
None yet
440A
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nejisama @taoyuanyuan
0