8000 Support date timezone by kepricon · Pull Request #791 · mongomock/mongomock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support date timezone #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 12, 2022
Merged

Support date timezone #791

merged 6 commits into from
Jul 12, 2022

Conversation

kepricon
Copy link
Contributor
@kepricon kepricon commented Jul 8, 2022 •
edited
Loading

What this PR does

  • support { date: , timezone: } format for date_operators such as $week, $year

related ticket

#783

@codecov
Copy link
codecov bot commented Jul 8, 2022 •
edited
Loading

Codecov Report

Merging #791 (b44bf58) into develop (b8d3199) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #791   +/-   ##
========================================
  Coverage    95.29%   95.29%           
========================================
  Files           20       20           
  Lines         3844     3849    +5     
========================================
+ Hits          3663     3668    +5     
  Misses         181      181
Impacted Files Coverage Δ
mongomock/aggregate.py 97.13% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8d3199...b44bf58. Read the comment docs.

pcorpet
pcorpet approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member
@pcorpet pcorpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR. Please address my few comments before I merge it.

@kepricon
Copy link
Contributor Author

@pcorpet thank you for the review.
I updated the PR.

when is the next release?

@pcorpet
Copy link
Member
pcorpet commented Jul 12, 2022

There is no regular release and I just did one last week. I'd rather wait August. Ping me again in a few weeks if you wish.

@pcorpet pcorpet merged commit d5fc4c7 into mongomock:develop Jul 12, 2022
@pcorpet pcorpet mentioned this pull request Jul 12, 2022
Closed
@kepricon kepricon deleted the support-date-timezone branch July 12, 2022 15:27
@kepricon kepricon mentioned this pull request Dec 12, 2022
Open
robberry90 pushed a commit to robberry90/mongomock that referenced this pull request Feb 4, 2023
@kepricon @robberry90
Support date timezone (mongomock#791)
cbf1a67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcorpet pcorpet pcorpet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
42E0 None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kepricon @pcorpet
0