8000 Add partialFilterExpression by zoebriois · Pull Request #784 · mongomock/mongomock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add partialFilterExpression #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2022
Merged

Add partialFilterExpression #784

merged 2 commits into from
Jul 7, 2022

Conversation

zoebriois
Copy link
Contributor
@zoebriois zoebriois commented Jul 2, 2022 •
edited
Loading

fixes #687

@pcorpet pcorpet closed this Jul 7, 2022
@pcorpet pcorpet reopened this Jul 7, 2022
@pcorpet
Copy link
Member
pcorpet commented Jul 7, 2022

I've closed and open this PR to trigger the CI

@pcorpet pcorpet force-pushed the partialFilterExpression branch from 67ce548 to 41880d4 Compare July 7, 2022 09:26
@codecov
Copy link
codecov bot commented Jul 7, 2022 •
edited
Loading

Codecov Report

Merging #784 (aedf9da) into develop (b48a387) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #784   +/-   ##
========================================
  Coverage    95.28%   95.29%           
========================================
  Files           20       20           
  Lines         3817     3822    +5     
========================================
+ Hits          3637     3642    +5     
  Misses         180      180
Impacted Files Coverage Δ
mongomock/collection.py 92.60% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48a387...aedf9da. Read the comment docs.

@pcorpet
Copy link
Member
pcorpet commented Jul 7, 2022

Hi @zoebriois , thanks for your change. I've cleaned up a bit the styling and fixed some of the calls.

@pcorpet pcorpet force-pushed the partialFilterExpression branch from 41880d4 to aedf9da Compare July 7, 2022 09:35
@pcorpet pcorpet mentioned this pull request Jul 7, 2022
Closed
@pcorpet pcorpet merged commit ae36245 into mongomock:develop Jul 7, 2022
robberry90 pushed a commit to robberry90/mongomock that referenced this pull request Feb 4, 2023
@zoebriois @pcorpet @robberry90
Add support for partialFilterExpression to create_index (mongomock#784)
e357766 
fixes mongomock#687

Co-authored-by: Zoé Briois <zoebriois@MacBook-Pro-Zoe-Briois.local>
Co-authored-by: Pascal Corpet <pascal@bayesimpact.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

createIndex don't support partialFilterExpression
2 participants
@zoebriois @pcorpet
0