8000 Add support for "number" alias in $type by guludo · Pull Request #757 · mongomock/mongomock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for "number" alias in $type #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2022
Merged

Add support for "number" alias in $type #757

merged 1 commit into from
Jul 7, 2022

Conversation

guludo
Copy link
Contributor
@guludo guludo commented Feb 6, 2022 •
edited
Loading

This is the third (based on top #756) and final PR made from the split of #743.

Best regards,
Gustavo Sousa

@codecov
Copy link
codecov bot commented Feb 6, 2022 •
edited
Loading

Codecov Report

Merging #757 (1ad763c) into develop (c00167c) will not change coverage.
The diff coverage is n/a.

❗ Current head 1ad763c differs from pull request most recent head 3b2de4a. Consider uploading reports for the commit 3b2de4a to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #757   +/-   ##
========================================
  Coverage    95.14%   95.14%           
========================================
  Files           19       19           
  Lines         3728     3728           
========================================
  Hits          3547     3547           
  Misses         181      181
Impacted Files Coverage Δ
mongomock/filtering.py 99.03% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c00167c...3b2de4a. Read the comment docs.

@guludo guludo mentioned this pull request Feb 6, 2022
Merged
@guludo guludo force-pushed the pr/type-add-number-alias branch from 1b740af to 0457f6c Compare February 15, 2022 14:09
@guludo
Copy link
Contributor Author
guludo commented Feb 15, 2022

Just rebased this on top of #756

@guludo guludo force-pushed the pr/type-add-number-alias branch 2 times, most recently from 3718404 to 1ad763c Compare February 21, 2022 11:22
pcorpet
pcorpet reviewed Feb 22, 2022
View reviewed changes
@guludo guludo force-pushed the pr/type-add-number-alias branch from 1ad763c to 3b2de4a Compare February 24, 2022 12:21
@pcorpet pcorpet merged commit ecb5fd1 into mongomock:develop Jul 7, 2022
robberry90 pushed a commit to robberry90/mongomock that referenced this pull request Feb 4, 2023
@guludo @robberry90
Add support for "number" alias in $type (mongomock#757)
47e78ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcorpet pcorpet pcorpet left review comments

Assignees
No one assigned
47B6
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guludo @pcorpet
0