Fix behavior for $type filter on numeric types #755
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #755 +/- ##
========================================
Coverage 95.14% 95.15%
========================================
Files 19 19
Lines 3731 3735 +4
========================================
+ Hits 3550 3554 +4
Misses 181 181
Continue to review full report at Codecov.
|
544b4d0 to
465d3fd
Compare
|
Force-pushed with changes required (comments where posted in #756). |
|
Please apply all the changes we added in #755 to simplify the map. |
|
Yes, sorry, I didn't mean to merge them, but all the remarks I made on #756 actually apply here. |
- Use correct type for "decimal" - Ensure that we do not confuse a Python `bool` for an `int` (since `isinstance(True, int)` evaluates as True). - Check on the bit-length of `int` values to check whether they should be considered "int" or "long" from Mongo's perspective. This patch adds the missing test for $type in `test__mongomock.py`. Note that the "array" type was purposefully ignored from `supported_types`, as there is an issue that will be solved in a future patch: `_type_op([1, 2, 3], t)` should return True for both `t = 'array'` and `t = 'int'`.
465d3fd to
f940150
Compare
|
Hi @pcorpet, Just updated this to have |
Hi there.
This is the first of 3 PRs made from splitting #743.
This makes changes so that we:
boolfor anint(sinceisinstance(True, int)evaluates as True).intvalues to check whether they shouldbe considered "int" or "long" from Mongo's perspective.
This patch adds the missing test for $type in
test__mongomock.py. Notethat the "array" type was purposefully ignored from
supported_types,as there is an issue that will be solved in a future patch:
_type_op([1, 2, 3], t)should return True for botht = 'array'andt = 'int'.