Make distinct() work with arrays of dicts #751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice fix. Thanks. |
|
I'm not ure why the CI didn't run. Can you try to rebase and push again please? |
17fecf9 to
548a806
Compare
Codecov Report
@@ Coverage Diff @@
## develop #751 +/- ##
========================================
Coverage 95.07% 95.07%
========================================
Files 19 19
Lines 3734 3734
========================================
Hits 3550 3550
Misses 184 184
Continue to review full report at Codecov.
|
|
Sure thing! |
|
Perfect, let's merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #750.