8000 Handling truthy and falsy values the way MongoDB does it by kosqx · Pull Request #651 · mongomock/mongomock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Handling truthy and falsy values the way MongoDB does it #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2020
Merged

Handling truthy and falsy values the way MongoDB does it #651

merged 1 commit into from
Aug 1, 2020

Conversation

kosqx
Copy link
Contributor
@kosqx kosqx commented Aug 1, 2020 •
edited
Loading

Fixes #650

@kosqx kosqx force-pushed the truthy-values branch 2 times, most recently from 43a477e to 15db8b2 Compare August 1, 2020 00:27
@codecov
Copy link
codecov bot commented Aug 1, 2020 •
edited
Loading

Codecov Report

Merging #651 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #651   +/-   ##
========================================
  Coverage    95.18%   95.18%           
========================================
  Files           17       17           
  Lines         3347     3347           
========================================
  Hits          3186     3186           
  Misses         161      161
Impacted Files Coverage Δ
mongomock/aggregate.py 97.50% <100.00%> (-0.01%) ⬇️
mongomock/helpers.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bb196c...8c545ed. Read the comment docs.

pcorpet
pcorpet approved these changes Aug 1, 2020
View reviewed changes
Copy link
Member
@pcorpet pcorpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. I'll wait for you to rebase and update the switch implementation as well.

@kosqx kosqx marked this pull request as ready for review August 1, 2020 11:11
@kosqx
Copy link
Contributor Author
kosqx commented Aug 1, 2020

I consider this PR to be done and ready to be merged.

@pcorpet pcorpet merged commit 9d5562e into mongomock:develop Aug 1, 2020
@kosqx kosqx deleted the truthy-values branch August 1, 2020 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcorpet pcorpet pcorpet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Falsy values in mongomock are different than in MongoDB
2 participants
@kosqx @pcorpet
0