Add $toDecimal operator #610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #610 +/- ##
===========================================
+ Coverage 94.70% 94.74% +0.04%
===========================================
Files 16 16
Lines 3190 3217 +27
===========================================
+ Hits 3021 3048 +27
Misses 169 169
Continue to review full report at Codecov.
|
|
I have add the test and fix all bugs which I know. Thank you for such thorough code review and quick response. |
pcorpet
requested changes
Mar 30, 2020
|
I have finalized the rest comments. Thank you. |
pcorpet
approved these changes
Mar 31, 2020
|
Congrats and thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I just fully implemented $toDecimal operator of aggregation convertor with UTs.
The original behaviors of $toDecimal can be found in https://docs.mongodb.com/manual/reference/operator/aggregation/toDecimal/#behavior
There is one behavior that doesn't have error detail in document is
After I check the real error from MongoDB, I confirm it will raise a OperationFailure with detail. I also implement it with a UT.
If it's convenient, would you like to check and merge this request.
PS： I may found a bug in the base function
_Parsewhen I wrote tests. I will open an issue for it later.Cheers!