8000 Implement the $addFields (alias $set) stage of aggregate. by pcorpet · Pull Request #574 · mongomock/mongomock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implement the $addFields (alias $set) stage of aggregate. #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2019
Merged

Implement the $addFields (alias $set) stage of aggregate. #574

merged 1 commit into from
Dec 16, 2019

Conversation

pcorpet
Copy link
Member
@pcorpet pcorpet commented Oct 25, 2019 •
edited
Loading

Implements #572

This change is Reviewable

@codecov
Copy link
codecov bot commented Oct 25, 2019 •
edited
Loading

Codecov Report

Merging #574 into develop will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #574      +/-   ##
===========================================
+ Coverage    94.68%   94.72%   +0.04%     
===========================================
  Files           16       16              
  Lines         3086     3111      +25     
===========================================
+ Hits          2922     2947      +25     
  Misses         164      164
Impacted Files Coverage Δ
mongomock/aggregate.py 97% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c730e...4e5f96a. Read the comment docs.

@pcorpet pcorpet mentioned this pull request Oct 25, 2019
Open
@pcorpet
Copy link
Member Author
pcorpet commented Oct 28, 2019

Also implements #555

@shapiy
Copy link
shapiy commented Dec 10, 2019

@pcorpet thanks for your great work first. Do you have an idea when this feature will be released?

@pcorpet
Copy link
Member Author
pcorpet commented Dec 11, 2019

@shapiy I'm waiting for a review. I'm an owner of this project but I prefer to have somebody else reviewing my code when I'm adding new features like this. Please take the time to review the changes and add comments if something is wrong or unclear.

@shapiy
Copy link
shapiy commented Dec 11, 2019 •
edited
Loading

@pcorpet I am not very familiar with the code base.

  • I see that the code is sustained in one style, is clean and without obvious mistakes.
  • I've installed mongomock from the feature branch and enabled my not-yet-passing unit test, and it works as expected.

If anyone is interested in testing:
pip install git+https://github.com/pcorpet/mongomock.git@set-pipeline

FYI,
While trying to post this comment with Reviewable, got this error:

Failed to publish: GitHub error 404 on POST https://api.github.com/repos/mongomock/mongomock/pulls/574/reviews: Not Found (The mongomock organization may need to authorize Reviewable as an accepted third party application.)

@pcorpet
Copy link
Member Author
pcorpet commented Dec 16, 2019

Thanks for your review. I'll go with that for now.

@pcorpet pcorpet merged commit 9b92a7e into mongomock:develop Dec 16, 2019
@pcorpet pcorpet deleted the set-pipeline branch December 16, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcorpet @shapiy
0