Add window support (2) #1636
Merged
Add window support (2) #1636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems to go in the right direction. But it seems to be missing code on how to set this via webinterface? |
|
I pushed new changes as best as I could. If anything is missing could you complete it? Thanks @markirb |
|
Judging by the looks only this seems okay. Did you test this? Can you share screenshots of the HomeApp? |
|
Managed to get it working! Used "Display as" to switch between Roller Shutter and Window, just below name settings. Here is the screenshot when it's added as a Window. I can now tell Siri to close/open my windows or blinds separately 😄 |
|
Very cool, thank you. I will review and try it in the next days hopefully and give it a short spin before this will be merged. |
markirb
reviewed
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on #766
The functionality would be really useful but there have been no follow-ups since 2021...
This entirely escaped my knowledge, but I tried to do it without duplicating window_covering.
Can @rojer @markirb confirm it works as expected?
Thanks in advance and sorry if there are any inconveniences. I have little to no idea what I'm doing.