8000 Romanian localization by gurdiga · Pull Request #326 · moment/moment · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Romanian localization #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Romanian localization #326

wants to merge 1 commit into from

Conversation

gurdiga
Copy link
@gurdiga gurdiga commented Jun 2, 2012

Hey Tim!

Here is the Romanian localization.

Thank you for the great moment! ;-)

@timrwood
Copy link
Member
timrwood commented Jun 4, 2012

Nice work! Th 8000 anks for contributing!

Mind writing unit tests as well? Something like this: https://github.com/timrwood/moment/blob/master/test/lang/ca.js

Also, please change the pull request to the develop branch, we only push to the master branch for a release.

@timrwood timrwood mentioned this pull request Jun 11, 2012
Closed
@rockymeza
Copy link
Contributor

Hi @gurdiga, in order to accept this language definition, we need some unit tests. Since we don't speak Romanian, we need somebody who does to write tests to ensure that the language definition isn't broken in the future.

Thanks

@gurdiga
Copy link
Author
gurdiga commented Jun 18, 2012

Sorry guys, I’m a bit busy right now. I will write the unit tests a bit later.

@rockymeza
Copy link
Contributor

Hi @gurdiga, just wanted to see if you were available to write the unit tests now. If not that's fine.

@gurdiga
Copy link
Author
gurdiga commented Jul 2, 2012

Terrible sorry guys, no, later.

@timrwood
Copy link
Member

I'm going to close this for now. Whenever you write unit tests, please resubmit to the develop branch and we will gladly accept it.

Thanks for contributing!

@timrwood timrwood closed this Jul 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gurdiga @timrwood @rockymeza
0