8000 Update it.js by pungggi · Pull Request #2690 · moment/moment · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update it.js #2690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update it.js #2690

wants to merge 1 commit into from

Conversation

pungggi
Copy link
@pungggi pungggi commented Oct 20, 2015

update weekdaysMin to 2 letters

update weekdaysMin to 2 letters
@mattjohnsonpint
Copy link
Contributor

@aliem @nostalgiaz @Oire Please review.

Some prior discussion in #262 (comment)

Also, there should be a corresponding unit test added to /src/test/locale/it.js. (There should have already been one which would have made this fail, but I don't see it.)

@ichernev
Copy link
Contributor

@pungggi can you reference some official document that states how should weekdays be abbreviated in Italian?

@zenlor
Copy link
Contributor
zenlor commented Nov 10, 2015

The official, or most used abbreviation is three letters:

  • lun
  • mar
  • mer
  • gio
  • ven
  • sab
  • dom

But the two or one letter versions are in use in the current language.

PS. sorry for not being very active lately.

@ichernev
Copy link
Contributor
ichernev commented Dec 1, 2015

This is already merged: fa77d56

@ichernev ichernev closed this Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0