8000 RF+BF: Move reporting code to own subpackage, break up big modules by moloney · Pull Request #15 · moloney/dcm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

RF+BF: Move reporting code to own subpackage, break up big modules #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RF+BF: Move reporting code to own subpackage, break up big modules #15

wants to merge 1 commit into from

Conversation

moloney
Copy link
Owner
@moloney moloney commented May 19, 2023

Few fixes/improvements around reporting. In particular stop raising exceptions in the setter for the done propety.

@moloney
RF+BF: Move reporting code to own subpackage, break up big modules
39a9b9a 
Few fixes/improvements around reporting. In particular stop raising
exceptions in the setter for the done propety.
@codecov-commenter
Copy link
codecov-commenter commented May 19, 2023 •
edited
Loading

Codecov Report

Patch coverage: 79.57% and project coverage change: -1.89 ⚠️

Comparison is base (b3f4e4c) 77.71% compared to head (39a9b9a) 75.82%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   77.71%   75.82%   -1.89%     
==========================================
  Files          25       24       -1     
  Lines        6407     5667     -740     
==========================================
- Hits         4979     4297     -682     
+ Misses       1428     1370      -58
Impacted Files Coverage Δ
dcm/reports/net_report.py 64.75% <64.75%> (ø)
dcm/reports/xfer_report.py 70.61% <70.61%> (ø)
dcm/store/base.py 70.78% <70.78%> (ø)
dcm/util.py 80.71% <78.94%> (+3.57%) ⬆️
dcm/lazyset.py 83.22% <84.00%> (+38.85%) ⬆️
dcm/router.py 87.54% <87.54%> (ø)
dcm/net.py 91.55% <88.78%> (+8.52%) ⬆️
dcm/cli.py 72.97% <89.28%> (+1.73%) ⬆️
dcm/reports/__init__.py 68.77% <92.68%> (ø)
dcm/node.py 95.83% <95.83%> (ø)
... and 12 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moloney @codecov-commenter
0