Enable benchmarks for pallet_xcm_benchmarks #3330

TarekkMA · 2025-06-26T18:14:27Z

⚠️ Breaking Changes ⚠️

Xcm instructions are now benchmarked and as a result the wights are now different than before

…pallet_xcm_benchmarks::generic`

coderabbitai · 2025-06-26T18:14:52Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

agent-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

TarekkMA · 2025-06-26T18:16:35Z

pallets/xcm-weight-trader/src/lib.rs

+			let weight = actual_weight.min(self.0);
+			let amount: u128 =
+				Self::compute_amount_to_charge(&weight, &location).unwrap_or(u128::MAX);
+			let amount_to_refund = initial_amount.saturating_sub(amount);
+			self.0 -= weight;
+			self.1 = Some(Asset {
+				fun: Fungibility::Fungible(amount_to_refund),
+				id: XcmAssetId(location.clone()),
+			});
+			log::trace!(
+				target: "xcm-weight-trader",
+				"refund_weight amount to refund: {:?}",
+				amount_to_refund
+			);
+			if amount > 0 {


Make the implementation the same as https://paritytech.github.io/polkadot-sdk/master/staging_xcm_builder/struct.UsingComponents.html

This resulted in fixing refund_surplus instruction benchmark test which was failing before.

TarekkMA · 2025-06-26T18:17:44Z

runtime/common/src/apis.rs

+							// 50 fungibles
+							const HOLDING_FUNGIBLES: u32 = 50;


Bring down the number of assets in the holding register to 50 to avoid ExceedsMaxMessageSize when running report_holding benchmark.

TarekkMA · 2025-06-26T18:18:39Z

runtime/common/src/apis.rs

@@ -986,14 +986,39 @@ macro_rules! impl_runtime_apis_plus_common {
 									);
 									XcmWeightTrader::set_asset_price(
 										location.clone(),
-										1u128.pow(18)
+										10u128.pow(18)


This typo resulted in miscalculation in the fee price price = (native_price * 10^18) / relative_price

TarekkMA · 2025-06-26T18:20:18Z

runtime/common/src/apis.rs

@@ -1112,9 +1144,6 @@ macro_rules! impl_runtime_apis_plus_common {

 					add_benchmarks!(params, batches);

-					if batches.is_empty() {
-						return Err("Benchmark not found for this pallet.".into());
-					}


These lines would cause benchmark to be reported as failed if it was skipped

Context: polkadot-fellows/runtimes#446

TarekkMA · 2025-06-26T18:22:08Z

runtime/moonbase/src/xcm_config.rs

@@ -113,10 +115,30 @@ parameter_types! {
 	};
 }

+#[cfg(feature = "runtime-benchmarks")]
+pub struct BenchAccountId32Aliases<AccountId>(PhantomData<AccountId>);


A workaround to pass this line https://github.com/paritytech/polkadot-sdk/blob/45cc86a4588fdae2929f9829f3a1d196a985afb5/polkadot/xcm/pallet-xcm-benchmarks/src/lib.rs#L111-L112

Since we don't use 32 byte accounts.

runtime/moonriver/src/xcm_config.rs

RomarQ · 2025-06-26T19:28:13Z

runtime/common/src/apis.rs

-						// 100 fungibles
-							const HOLDING_FUNGIBLES: u32 = 100;
+							// 50 fungibles
+							const HOLDING_FUNGIBLES: u32 = 50;


Maybe we could even do:

Suggested change

const HOLDING_FUNGIBLES: u32 = 50;

const HOLDING_FUNGIBLES: u32 = MaxAssetsIntoHolding::get();

github-actions · 2025-06-27T08:28:38Z

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2372 KB (-8 KB) ✅

Moonbeam runtime: 2356 KB (-16 KB) ✅

Moonriver runtime: 2360 KB (-12 KB) ✅

Compared to latest release (runtime-3701)

Moonbase runtime: 2372 KB (+316 KB compared to latest release) ⚠️

Moonbeam runtime: 2356 KB (+308 KB compared to latest release) ⚠️

Moonriver runtime: 2360 KB (+308 KB compared to latest release) ⚠️

Enable benchmarks for pallet_xcm_benchmarks and fix all issues with `…

7ce8a70

…pallet_xcm_benchmarks::generic`

TarekkMA commented Jun 26, 2025

View reviewed changes

RomarQ added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Jun 26, 2025

RomarQ reviewed Jun 26, 2025

View reviewed changes

runtime/moonriver/src/xcm_config.rs Outdated Show resolved Hide resolved

RomarQ reviewed Jun 26, 2025

View reviewed changes

Cleanup AccountIdConverter

6af17ba

TarekkMA added the breaking Needs to be mentioned in breaking changes label Jun 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Enable benchmarks for pallet_xcm_benchmarks #3330

Enable benchmarks for pallet_xcm_benchmarks #3330

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

	const HOLDING_FUNGIBLES: u32 = 50;
	const HOLDING_FUNGIBLES: u32 = MaxAssetsIntoHolding::get();

Enable benchmarks for pallet_xcm_benchmarks #3330

Are you sure you want to change the base?

Enable benchmarks for pallet_xcm_benchmarks #3330

Conversation

Uh oh!

⚠️ Breaking Changes ⚠️

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WASM runtime size check:

Compared to target branch

Compared to latest release (runtime-3701)

Uh oh!

Uh oh!

CodeRabbit Configuration File (`.coderabbit.yaml`)