Validate depth limit decoding in XCM transact instruction #3309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WASM runtime size check:Compared to target branchMoonbase runtime: 2372 KB (no changes) ✅ Moonbeam runtime: 2364 KB (no changes) ✅ Moonriver runtime: 2352 KB (no changes) ✅ Compared to latest release (runtime-3701)Moonbase runtime: 2372 KB (+316 KB compared to latest release) Moonbeam runtime: 2364 KB (+316 KB compared to latest release) Moonriver runtime: 2352 KB (+300 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master rq/add-xcm-transact-depth-decoding-test +/- ##
===========================================================================
+ Coverage 75.35% 75.39% +0.04%
Files 407 407
+ Lines 101476 101572 +96
===========================================================================
+ Hits 76462 76573 +111
- Misses 25014 24999 -15
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This test adds a simple validation to make we will detect if
MAX_XCM_DECODE_DEPTHchanges in future polkadot-sdk versions.