8000 Bridge (Moonbeam <-> Moonriver) by RomarQ · Pull Request #3188 · moonbeam-foundation/moonbeam · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bridge (Moonbeam <-> Moonriver) #3188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 66 commits into
base: master
Choose a base branch
from
Draft

Bridge (Moonbeam <-> Moonriver) #3188

wants to merge 66 commits into from
+5,673 −8,263

Conversation

RomarQ
Copy link
Contributor
@RomarQ RomarQ commented Feb 6, 2025 •
edited
Loading

What does it do?

Configures the moonbeam and moonriver runtimes with new pallets and primitives for enabling XCM bridging between them.

Relayer binary: https://github.com/Moonsong-Labs/parity-bridges-common

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@RomarQ RomarQ self-assigned this Feb 6, 2025
@RomarQ RomarQ changed the title Bridge PoC Bridge MVP Feb 25, 2025
@RomarQ RomarQ added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes not-breaking Does not need to be mentioned in breaking changes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Feb 25, 2025
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Feb 25, 2025 •
edited
Loading

Moonbase Weight Difference Report

File Extrinsic Old New Change Percent

Moonriver Weight Difference Report

File Extrinsic Old New Change Percent

Moonbeam Weight Difference Report

File Extrinsic Old New Change Percent

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Feb 26, 2025 •
edited
Loading

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2368 KB (+4 KB) ⚠️

Moonbeam runtime: 2552 KB (+200 KB) 🚨

Moonriver runtime: 2552 KB (+196 KB) 🚨

Compared to latest release (runtime-3701)

Moonbase runtime: 2368 KB (+312 KB compared to latest release) ⚠️

Moonbeam runtime: 2552 KB (+504 KB compared to latest release) 🚨

Moonriver runtime: 2552 KB (+500 KB compared to latest release) 🚨

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Feb 26, 2025 •
edited
Loading

Coverage Report

@@                 Coverage Diff                 @@
##           master   rq/bridge-setup      +/-   ##
===================================================
- Coverage   74.25%            73.64%   -0.61%     
- Files         415               411       -4     
- Lines      103355            100509    -2846     
===================================================
- Hits        76738             74013    -2725     
- Misses      26617             26496     -121
Files Changed Coverage
/pallets/ethereum-xcm/src/lib.rs 89.71% (+9.71%) 🔼
/pallets/moonbeam-foreign-assets/src/lib.rs 82.53% (+2.21%) 🔼
/pallets/xcm-weight-trader/src/lib.rs 88.93% (+1.59%) 🔼
/primitives/xcm/src/origin_conversion.rs 93.88% (+4.08%) 🔼
/runtime/common/src/apis.rs 85.28% (+0.02%) 🔼
/runtime/moonbase/tests/common/mod.rs 95.15% (+1.52%) 🔼
/runtime/moonbeam/src/lib.rs 49.11% (-2.90%) 🔽
/runtime/moonbeam/src/weights/xcm/fungible.rs 45.45% (+21.21%) 🔼
/runtime/moonbeam/src/weights/xcm/generic.rs 8.83% (+5.09%) 🔼
/runtime/moonbeam/src/weights/xcm/mod.rs 23.44% (+11.00%) 🔼
/runtime/moonbeam/src/xcm_config.rs 63.46% (+1.92%) 🔼
/runtime/moonbeam/tests/common/mod.rs 95.57% (+0.47%) 🔼
/runtime/moonbeam/tests/integration_test.rs 99.39% (+0.05%) 🔼
/runtime/moonriver/src/lib.rs 48.86% (-2.90%) 🔽
/runtime/moonriver/src/weights/xcm/fungible.rs 45.45% (+33.33%) 🔼
/runtime/moonriver/src/weights/xcm/generic.rs 7.54% (+3.85%) 🔼
/runtime/moonriver/src/weights/xcm/mod.rs 22.01% (+11.96%) 🔼
/runtime/moonriver/src/xcm_config.rs 63.46% (+1.92%) 🔼
/runtime/moonriver/tests/common/mod.rs 95.65% (+0.44%) 🔼
/runtime/moonriver/tests/integration_test.rs 99.36% (+0.04%) 🔼

Coverage generated Thu Jun 26 13:01:37 UTC 2025

@RomarQ RomarQ requested a review from Copilot April 7, 2025 14:05
Copilot
Copilot AI reviewed Apr 7, 2025
View reviewed changes
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 65 out of 66 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • Makefile: Language not supported
Comments suppressed due to low confidence (2)

node/service/src/chain_spec/moonbeam.rs:146

  • [nitpick] Consider expanding this comment with additional context on how the Bridge account is derived to aid future maintainers.< 10000 /li> 
// Bridge Location::new(1, [Parachain(<bp_moonbeam::Moonbeam as bp_runtime::Parachain>::PARACHAIN_ID)])

Cargo.toml:57

  • [nitpick] Ensure that using the 2021 edition here aligns with the rest of the workspace settings for consistency across packages.
edition = "2021"

RomarQ added 20 commits April 24, 2025 11:43
@RomarQ
feat(bridge): add pallet_bridge_grandpa
2fc6692
@RomarQ
add Makefile and zombienet setup
df084e6
@RomarQ
update zombienet setup
f7f3abe
@RomarQ
feat: convert ecdsa::Public to AccountId
6ce07aa
@RomarQ
add bridge primitives for moonbeam and moonriver
9b69e63
@RomarQ
add pallet bridge parachains to moonriver and moonbeam runtimes
44bdda9
@RomarQ
expose common types
1788013
@RomarQ
add common bridge primitives
c3148a0
@RomarQ
add UncheckedExtrinsic type
5ed871c
@RomarQ
🎩 update macro impl_runtime_apis_plus_common to support benchmarking …
d9352b5 
…customizations and generate weights
@RomarQ
test pallet presence
229f9d8
@RomarQ
enable bridge benchmarks for moonbeam runtime
ec6658b
@RomarQ
revert change
3371a28
@RomarQ
update bridge primitives
033868e
@RomarQ
Add implementation: From<ecdsa::Public> for AccountId20
15fa0a4
@RomarQ
update bridge primitives
7bbe82a
@RomarQ
integrate pallet_xcm_bridge_hub
ca2584d
@RomarQ
update genesis state
9cf9985
@RomarQ
add rust tests
7718cf0
@RomarQ
configure bridge in runtimes
55ae921
RomarQ added 30 commits June 18, 2025 16:00
@RomarQ
clean-up
410b261
@RomarQ
removed unused import
ec70420
@RomarQ
removed unused code
78b438d
@RomarQ
fix test
5654431
@RomarQ
Merge branch 'master' into rq/bridge-setup
416fc3b
@RomarQ
fix tests
bec03f6
@RomarQ
clean-up
b88732b
@RomarQ
fix tests
a42e541
@RomarQ
remove pallet_xcm_bridge_router instance
274fb89
@RomarQ
add bridge xcm router
b1d14d4
@RomarQ
update Cargo.lock
0aedcf4
@RomarQ
add pallet_bridge_messages weights
4c65ddf
@RomarQ
Merge branch 'master' into rq/bridge-setup
5603862
@RomarQ
update Cargo.lock
20908e1
@RomarQ
enabled universal origin XCM instruction
f8b3964
@RomarQ
enabled universal_origin for moonbase and moonbeam
3a94521
@RomarQ
fix tests
dcb1f3e
@RomarQ
fix rust tests
eabe3b8
@RomarQ
fix e2e tests
b5783d0
@RomarQ
fix rust tests
a961ef8
@RomarQ
Merge branch 'master' into rq/bridge-setup
1cd58d5
@RomarQ
remove xcm-bridge-router
c0560ac
@RomarQ
Revert "remove xcm-bridge-router"
fa5b46b 
This reverts commit c0560ac.
@RomarQ
Revert "Revert "remove xcm-bridge-router""
0ca9894 
This reverts commit fa5b46b.
@RomarQ
removed bridge xcm pallets
ebb3827
@RomarQ
revert chnages to download-polkadot.sh
a0c8827
@RomarQ
add benchmarks
e4a1651
@RomarQ
removed unused import
82cdd0a
@RomarQ
fix benchmarks
61d1181
@RomarQ
fix
1626c42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@RomarQ RomarQ

Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes B10-Bridge This pull request touches on the bridge functionality D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RomarQ
0