8000 Feature/#767 design event,auditing and error framework proposal by mdebarros · Pull Request #85 · mojaloop/documentation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature/#767 design event,auditing and error framework proposal #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Jun 28, 2019
Merged

Feature/#767 design event,auditing and error framework proposal #85

merged 40 commits into from
Jun 28, 2019

Conversation

mdebarros
Copy link
Member
@mdebarros mdebarros commented Jun 14, 2019 •
edited
Loading

Design for Event Framework based on DA review and PoC findings.

mdebarros and others added 26 commits June 4, 2019 16:42
@mdebarros
added initial draft for event framework
57fedab
@mdebarros
Fix to colour typo for PI6 component diagram
585997b
@mdebarros
updated to event design
de9d18d
@mdebarros
updated event arch
8c999ba
@mdebarros
fix typo
a66a424
@mdebarros
updates for tracing
de91273
@mdebarros
updated event arch diag
d19933b
@mdebarros
event updates
b8e8e89
@mdebarros
update
1369d03
@mdebarros
updated trace design
ca6f2bb
@mdebarros
updated event info
7d04235
10000
@mdebarros
change case of directory to lower
9875fd4
@mdebarros
updates to event arch
faa9fcd
@mdebarros
updated event design
82f2bd8
@ramirogm
Update example and typos
de5d8df 
- `metadata.event.type` and `metadata.event.action` had invalid values according to the enum definition
- `code` is a `number` not `string`
- `spanId` should be `parentSpanId`
@ramirogm
README.md use trace/start type/action
3b0defd
@mdebarros
Merge pull request #3 from ramirogm/patch-1
52bc13e 
Update example and typos

Thanks @ramirogm!
@mdebarros
updated arch for events
c4840fa
@mdebarros
updated event arch
db36dbe
@mdebarros
updates to event design
c42d944
@mdebarros
aligned data types with Event SDK implementation
85854f8
@mdebarros
updated readme to include disclaimer
f2e5b0a
@mdebarros
Merge remote-tracking branch 'mojaloop/master' into feature/#767Desig…
f2e7930 
…nEvent,AuditingandErrorFrameworkProposal
@mdebarros
updated event arch diagram
4071708
@mdebarros
Updated event framework arch
52a966a
@mdebarros
Minor updates to the event framework model specification
8af49ec
@elnyry-sam-k elnyry-sam-k changed the title Feature/#767 design event,auditingand error framework proposal Feature/#767 design event,auditing and error framework proposal Jun 21, 2019
@elnyry-sam-k
Copy link
Member

Thanks Miguel @mdebarros , a couple of comments, one major and two optional ones:

  1. Usage of "X-" for headers has been deprecated as per RFC 6648 - https://tools.ietf.org/html/rfc6648
  2. Optional: In section 3.2.1.5 - If 'failed' in the negative value, the positive value should be 'succeeded' otherwise, for 'success', 'failure' or 'fail' is probably a better value
  3. Optional: A separate column to specify Optional and Required fields in the data models will give more clarity

elnyry-sam-k
elnyry-sam-k previously approved these changes Jun 21, 2019
View reviewed changes
@mdebarros
Copy link
Member Author

@elnyry please see my updates as follows:

  1. Usage of "X-" for headers has been deprecated as per RFC 6648 - https://tools.ietf.org/html/rfc6648

Not for the zipkin headers as they do not follow any RFC standard.

  1. Optional: In section 3.2.1.5 - If 'failed' in the negative value, the positive value should be 'succeeded' otherwise, for 'success', 'failure' or 'fail' is probably a better value

Updated to fail as per your comment.

  1. Optional: A separate column to specify Optional and Required fields in the data models will give more clarity

Added additional column mandatory.

elnyry-sam-k
elnyry-sam-k previously approved these changes Jun 24, 2019
View reviewed changes
@mdebarros mdebarros mentioned this pull request Jun 28, 2019
Closed
14 tasks
@mdebarros mdebarros requested a review from elnyry-sam-k June 28, 2019 15:21
@mdebarros mdebarros merged commit 8473b13 into mojaloop:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elnyry-sam-k elnyry-sam-k elnyry-sam-k approved these changes

@kjw000 kjw000 Awaiting requested review from kjw000

@millerabel millerabel Awaiting requested review from millerabel millerabel is a code owner

@NicoDuvenage NicoDuvenage Awaiting requested review from NicoDuvenage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdebarros @elnyry-sam-k @ramirogm
0