8000 Fix Custom Property Sets not working after upgrade to MODX 3 by JoshuaLuckers · Pull Request #16337 · modxcms/revolution · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Custom Property Sets not working after upgrade to MODX 3 #16337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2023
Merged

Fix Custom Property Sets not working after upgrade to MODX 3 #16337

merged 1 commit into from
Jan 12, 2023

Conversation

JoshuaLuckers
Copy link
Contributor

What does it do?

Update legacy class references in modElementPropertySet::class element_class column

Why is it needed?

This will fix Custom Property Sets not working after upgrade to MODX 3.

How to test

  • Create a custom property set in 2.x and attach various elements to it (e.g a snippet).
  • Upgrade to MODX 3.0.3-dev (build from this PR)

Related issue(s)/PR(s)

Resolves #16332

@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Dec 24, 2022
@JoshuaLuckers JoshuaLuckers added this to the v3.0.3 milestone Dec 24, 2022
@JoshuaLuckers JoshuaLuckers added the pr/review-needed Pull request requires review and testing. label Dec 24, 2022
@codecov-commenter
Copy link
codecov-commenter commented Dec 24, 2022 •
edited
Loading

Codecov Report

Base: 16.91% // Head: 17.84% // Increases project coverage by +0.93% 🎉

Coverage data is based on head (6c4948b) compared to base (680df53).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@             Coverage Diff              @@
##                3.x   #16337      +/-   ##
============================================
+ Coverage     16.91%   17.84%   +0.93%     
+ Complexity    10447    10437      -10     
============================================
  Files           561      561              
  Lines         38028    39033    +1005     
============================================
+ Hits           6433     6967     +534     
- Misses        31595    32066     +471
Impacted Files Coverage Δ
core/src/Revolution/modDocument.php 50.00% <0.00%> (-12.50%) ⬇️
core/src/Revolution/Processors/Element/Get.php 50.00% <0.00%> (-5.00%) ⬇️
core/src/Revolution/Processors/Context/GetList.php 75.00% <0.00%> (-5.00%) ⬇️
core/src/Revolution/Processors/Element/GetList.php 78.57% <0.00%> (-4.77%) ⬇️
core/src/Revolution/Processors/Element/Update.php 63.04% <0.00%> (-4.40%) ⬇️
...olution/Processors/Element/PropertySet/GetList.php 48.78% <0.00%> (-4.00%) ⬇️
...ssors/Security/User/GetRecentlyEditedResources.php 27.14% <0.00%> (-3.51%) ⬇️
...e/src/Revolution/Processors/System/ConfigCheck.php 76.22% <0.00%> (-2.67%) ⬇️
core/src/Revolution/modAccessCategory.php 53.84% <0.00%> (-2.41%) ⬇️
core/src/Revolution/Mail/modMail.php 39.08% <0.00%> (-2.39%) ⬇️
... and 107 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JoshuaLuckers JoshuaLuckers mentioned this pull request Dec 24, 2022
Merged
@JoshuaLuckers
Update legacy class references in modElementPropertySet::class `ele…
6c4948b 
…ment_class` column

This will fix Custom Property Sets not working after upgrade to MODX 3.
@Mark-H
Copy link
Collaborator
Mark-H commented Jan 11, 2023

Note this PR is blocking #16338.

@Ibochkarev Ibochkarev added pr/ready-for-merging Pull request reviewed and tested and ready for merging. and removed pr/review-needed Pull request requires review and testing. labels Jan 11, 2023
@opengeek opengeek merged commit 073f9b8 into modxcms:3.x Jan 12, 2023
@JoshuaLuckers JoshuaLuckers deleted the fix/issue-16332 branch January 12, 2023 01:47
@Mark-H Mark-H mentioned this pull request Jan 24, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jako Jako Jako approved these changes

@Mark-H Mark-H Mark-H approved these changes

@opengeek opengeek Awaiting requested review from opengeek opengeek is a code owner

Assignees
No one assigned
Labels
cla-signed CLA confirmed for contributors to this PR. pr/ready-for-merging Pull request reviewed and tested and ready for merging.
Projects
None yet
Milestone
v3.0.3
Development

Successfully merging this pull request may close these issues.

Custom Property Sets not working after upgrade to MODX 3
6 participants
@JoshuaLuckers @codecov-commenter @Mark-H @Jako @opengeek @Ibochkarev
0