FIX-#2857: Correctly handle identical index binary operations #2862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions Resolves modin-project#2857 Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2862 +/- ##
===========================================
- Coverage 82.34% 68.95% -13.39%
===========================================
Files 132 132
Lines 14480 14508 +28
===========================================
- Hits 11923 10004 -1919
- Misses 2557 4504 +1947
Continue to review full report at Codecov.
|
|
|
|
RehanSD
reviewed
Mar 12, 2021
| @@ -1783,8 +1783,6 @@ def get_axis_lengths(partitions, axis): | |||
| return self._partitions, [o._partitions for o in other], joined_index | |||
|
|
|||
| base_frame_idx = non_empty_frames_idx[0] | |||
There was a problem hiding this comment.
Why do we define this variable if we only use it in line 1786? Why not use it in line 1789 as well?
There was a problem hiding this comment.
The code quality in this helper method is in need of some TLC, I do not disagree. Let's put that later.
| @@ -973,7 +973,7 @@ def merge(left_index, right_index): | |||
| return left_index.join(right_index, how=how, sort=sort) | |||
|
|
|||
| # define condition for joining indexes | |||
| all_indices_equal = all(indexes[0].equals(index) for index in [indexes[1:]]) | |||
| all_indices_equal = all(indexes[0].equals(index) for index in indexes[1:]) | |||
There was a problem hiding this comment.
I'm not sure I understand what these changes do - before were we making a 2D list with one row that contains indices, but now we're just looping through the list of indices?
There was a problem hiding this comment.
Yes, it was a bug. Deleting these two characters fixes the case in the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2857
Signed-off-by: Devin Petersohn devin.petersohn@gmail.com
What do these changes do?
flake8 modinblack --check modingit commit -s