-
Notifications
You must be signed in to change notification settings - Fork 665
FIX-#2859: Fix metadata calculation on reduce operations #2860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Resolves modin-project#2859 Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2860 +/- ##
===========================================
- Coverage 82.34% 66.11% -16.23%
===========================================
Files 132 132
Lines 14480 14504 +24
===========================================
- Hits 11923 9589 -2334
- Misses 2557 4915 +2358
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - just left some comments for my personal clarification. Based off of the changes, it seems that the default behavior is the preserve_index
behavior. I just wanted to confirm that that's the case.
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Resolves #2859
Signed-off-by: Devin Petersohn devin.petersohn@gmail.com
What do these changes do?
flake8 modin
black --check modin
git commit -s