Fix bug with 2 separate PDFJS objects, add more Node/Bun tests in CI
#384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Electroid I'm a big fan of your work! Unfortunately I cannot take action on this PR, but the code looks good! Also, keeping support for older versions of NodeJs is always a plus. |
modesty
requested changes
Apr 5, 2025
| "test": "jest --config ./jest.config.json && npm run parse-r && npm run parse-fd", | ||
| "pretest:node": "npm run build", | ||
| "test:node": "jest && npm run parse-r && npm run parse-fd", | ||
| "pretest:bun": "npm run build", |
There was a problem hiding this comment.
what's the reason to add pretest:bun while unused and same as existing pretest ?
better leave pretest, test as before, and add xxx:bun, so that it'd won't break existing devop automation.
| `pretest` step builds bundles and source maps for both ES Module and CommonJS, output to `./dist` directory. The Jest test suit is defined in `./test/_test_.cjs` with commonJS, test run will also cover `parse-r` and `parse-fd` with ES Modules via command line. | ||
| ```bash | ||
| bun run test:bun # runs in Bun | ||
| bun run test:node # runs in Node.js using Jest |
There was a problem hiding this comment.
better keep npm test as to not breaking existing devop automation.
keep the bun related info as extension, not replacement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where there were 2 separate
PDFJSobjects, and adds support to run tests in Bun.Electroid@69ecd47 fixes the
PDFJSbugElectroid@f516266 & Electroid@c5725b5 make changes so Node 18.x, 20.x, 22.x and Bun 1.x are tested in CI
Thanks for working on this package and happy to help!