8000 Add ProxyFromEnvironment enables client via proxy. by andersjanmyr · Pull Request #9951 · moby/moby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add ProxyFromEnvironment enables client via proxy. #9951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2015
Merged

Add ProxyFromEnvironment enables client via proxy. #9951

merged 1 commit into from
Jan 13, 2015

Conversation

andersjanmyr
Copy link
Contributor

Enables http.ProxyFromEnvironment as done in http.DefaultTransport.
It allows a client to connect to a server through a proxy with http_proxy environment variables set
as described in the source code: https://golang.org/src/net/http/transport.go, line 34

Fixes #8751

Signed-off-by: Anders Janmyr anders@janmyr.com

@jessfraz
Copy link
Contributor
jessfraz commented Jan 8, 2015

can you please go fmt the files with gofmt -s -w then amend the result with git commit --amend -a --no-edit && git push -f

@andersjanmyr
Add ProxyFromEnvironment enables client via proxy.
43d45e6 
Signed-off-by: Anders Janmyr <anders@janmyr.com>
@andersjanmyr andersjanmyr force-pushed the add-proxy-from-environment-to-client branch from 08c438b to 43d45e6 Compare January 8, 2015 07:12
@andersjanmyr
Copy link
Contributor Author

Ok, done! Sorry about that, I'll add it to my git hook.

@crosbymichael
Copy link
Contributor

LGTM

1 similar comment
8000
@jessfraz
Copy link
Contributor

LGTM

jessfraz pushed a commit that referenced this pull request Jan 13, 2015
Merge pull request #9951 from andersjanmyr/add-proxy-from-environment…
ab86f59 
…-to-client

Add ProxyFromEnvironment enables client via proxy.
@jessfraz jessfraz merged commit ab86f59 into moby:master Jan 13, 2015
@coolljt0725
Copy link
Contributor

@jfrazelle @andersjanmyr @crosbymichael It seems something wrong because of this PR or am I missing something.I set up http_proxy and https_proxy on my machine, then the docker client never work, it return FATA[0000] Error response from daemon: 404 page not found . And when I unset http_proxy and https_proxy,it works fine. What should I do if I want to use the http_proxy and https_proxy?

@coolljt0725 coolljt0725 mentioned this pull request Jan 16, 2015
Closed
@icecrime icecrime mentioned this pull request Jan 19, 2015
Merged
@thaJeztah thaJeztah mentioned this pull request Jan 20, 2015
Closed
@thaJeztah
Copy link
Member

Someone else reported the 404 error using master in #10224 (comment)

Could be a user error, but thought I'd mention it here as well

@thaJeztah
Copy link
Member

Sorry for my previous comment; I just saw the extra notes in the documentation (https://github.com/docker/docker/pull/10192/files) covering that case.

@thaJeztah thaJeztah mentioned this pull request Jan 25, 2015
Merged
@SvenDowideit SvenDowideit mentioned this pull request Jan 27, 2015
Merged
@dduportal dduportal mentioned this pull request Feb 11, 2015
Closed
@cpuguy83 cpuguy83 mentioned this pull request Feb 12, 2015
Closed
@icecrime icecrime mentioned this pull request Feb 12, 2015
Merged
@thaJeztah thaJeztah mentioned this pull request Apr 14, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker client ignore repository https port
5 participants
@andersjanmyr @jessfraz @crosbymichael @coolljt0725 @thaJeztah
0