restart: Fix an error about arguments missing #9919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function shouldRestart() checks the restart policy and records the debug info and there should be two arguments in the log.Debugf(). Prior to the this patch, the logs were something like this: - client: $ docker run --restart=on-failure:3 ubuntu /bin/sh -c 'exit 1' - daemon: INFO[0168] ... DEBU[0168] stopping restart of container %!s(int=3) because maximum failure could of %!d(MISSING) has been reached INFO[0086] ... Btw, fix a spelling error in the same file: - cotnainer -> container ---------------------------------------- Signed-off-by: Hu Keping <hukeping@huawei.com>
|
damn nice find LGTM |
|
LGTM |
LK4D4
added a commit
that referenced
this pull request
Jan 6, 2015
restart: Fix an error about arguments missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arguments missing in function shouldRestart()
When we specify the restart policy as:
$ docker run --restart=on-failure:3 ubuntu /bin/sh -c 'exit 1'
The debug info output by the daemon is like:
DEBU[0168] stopping restart of container %!s(int=3) because maximum failure could of %!d(MISSING) has been reached