8000 Add docker-py tests to drone. by jessfraz · Pull Request #9914 · moby/moby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add docker-py tests to drone. #9914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2015
Merged

Add docker-py tests to drone. #9914

merged 1 commit into from
Jan 6, 2015

Conversation

jessfraz
Copy link
Contributor
@jessfraz jessfraz commented Jan 5, 2015

because yolo

@tianon
Copy link
Member
tianon commented Jan 5, 2015

👍

(although, at this point, why not just drop the whole list and run hack/make.sh by itself, which should run everything? https://github.com/docker/docker/blob/25f8c2664066a523f3f59f4cc5cdc8cf81c8a7c8/project/make.sh#L43-L63)

@jessfraz
Copy link
Contributor Author
jessfraz commented Jan 5, 2015

ok ok i updated

@LK4D4
Copy link
Contributor
LK4D4 commented Jan 5, 2015

@tianon isn't dyntest-unit will be pretty slow? Cause even now it takes enormous time to test one PR.

@tianon
Copy link
Member
tianon commented Jan 5, 2015

True, but it runs everything, which is strictly better than what we do now, right? This will even build-test creating the tarballs and the debs, so that if Drone's happy, we can be reasonably assured that the PR doesn't break the build.

@jessfraz
Copy link
Contributor Author
jessfraz commented Jan 5, 2015

nice ya, the more the merrier

@jessfraz
Copy link
Contributor Author
jessfraz commented Jan 5, 2015

lets see how long it takes

@LK4D4
Copy link
Contributor
LK4D4 commented Jan 5, 2015

/me already caught Follow button

@jessfraz
Copy link
Contributor Author
jessfraz commented Jan 5, 2015

that's the hardest part

@thaJeztah
Copy link
Member

Not sure if it makes sense, but would it be possible to check if only "doc" changes are made? (Ie only changes inside /docs or only *.md files? Would save a lot of time and perhaps some trees. 🌳.

@LK4D4
Copy link
Contributor
LK4D4 commented Jan 5, 2015

Haha, failed. And there is no logs in webui too.

@jessfraz
Copy link
Contributor Author
jessfraz commented Jan 5, 2015

ugh gross im going back to the other thing bc that succeeded

@jessfraz
Copy link
Contributor Author
jessfraz commented Jan 5, 2015

ok updated... i also have jenkins doing everything so at least theres that .. https://jenkins.dockerproject.com/job/Docker%20Master/label=debian-devmapper-lxc/128/console

@jessfraz
Add docker-py tests to drone.
a1bfe3a 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <jess@docker.com> (github: jfrazelle)
@LK4D4
Copy link
Contributor
LK4D4 commented Jan 5, 2015

LGTM

1 similar comment
@crosbymichael
Copy link
Contributor

LGTM

crosbymichael added a commit that referenced this pull request Jan 6, 2015
@crosbymichael
Merge pull request #9914 from jfrazelle/drone-py
f0d7616 
Add docker-py tests to drone.
@crosbymichael crosbymichael merged commit f0d7616 into moby:master Jan 6, 2015
@tianon
Copy link
Member
tianon commented Jan 6, 2015

/me sheds another tear for drone :poo:

@jessfraz jessfraz deleted the drone-py branch January 6, 2015 19:34
@SvenDowideit SvenDowideit mentioned this pull request Jan 27, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jessfraz @tianon @LK4D4 @thaJeztah @crosbymichael
0